New issue
Advanced search Search tips

Issue 845266 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Flaky timeout: virtual/gpu-rasterization/images/color-profile-image-filter-all.html

Project Member Reported by qyears...@chromium.org, May 21 2018

Issue description

Comment 1 by atotic@chromium.org, May 21 2018

My guess on root cause:

https://chromium-review.googlesource.com/c/chromium/src/+/1005017

"In order to be able to use SwiftShader on the bots, use_egl must be true
so that the EGL codepath is compiled into the executable."

It happened right before tests got flakey.

This CL already had 2 unexpected failures in the first run.

virtual/gpu-rasterization/images/2-comp.html
virtual/gpu-rasterization/images/cross-fade-svg-fragments.html

The note on the commit says:
""
*** PLEASE DO NOT REVERT THIS CL ***
(unless there's a major issue of course)

If a few layout tests fail or are slow on the bots, please add them to:
third_party/WebKit/LayoutTests/TestExpectations
or
third_party/WebKit/LayoutTests/SlowTests
instead of reverting the entire cl.
"
Cc: sugoi@chromium.org
That sounds like a reasonable guess.

This test also apparently has had a history of flaky failure; it was listed on 2018-02-19 as failure for Mac in TestExpectations, with a line associated with  bug 771643 . Although it's possible that the current flaky timeout is related to the change to set use_egl to true.

Comment 3 by sugoi@chromium.org, May 22 2018

Note that it's expected that, while switching from OSMesa to SwiftShader fixes many issues, it can introduce some flakiness in some tests at the beginning, but these issues should be ironed out as we fix these one by one. It is perfectly acceptable to add flaky tests to the TestExpectations file, pointing to  issue 726075 , and we will try to solve all these issues as soon as possible.
virtual/gpu-rasterization/images/cross-fade-svg-fragments.html seems to be flaky on Mac10.12 Tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13291
Project Member

Comment 5 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48c45d493dcc88b58a99950d2005bccc4ffd92d

commit c48c45d493dcc88b58a99950d2005bccc4ffd92d
Author: Luna Lu <loonybear@chromium.org>
Date: Mon May 28 19:29:44 2018

mark virtual/gpu-rasterization/images/cross-fade-svg-fragments.html flaky

Bug:  845266 
Change-Id: Ie51827b89aa95d624430c00f21dc1e431a863861
Reviewed-on: https://chromium-review.googlesource.com/1075713
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562300}
[modify] https://crrev.com/c48c45d493dcc88b58a99950d2005bccc4ffd92d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f73246ba7034539dbda70502ec21b53b06cd68b3

commit f73246ba7034539dbda70502ec21b53b06cd68b3
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Jun 06 16:56:27 2018

Re-enable some disabled MacOS Layout Tests

Now that synchronization issues have been fixed on MacOS,
most previously disabled layout tests can be re-enabled.

TBR=kbr@chromium.org
Bug: chromium:726075   chromium:646528   chromium:845267  chromium:614910  chromium:845266  chromium:791941  chromium:847094   chromium:849256 

Change-Id: Ifa59c2594c429a94643ea9f19b2e08e974cc6c53
Reviewed-on: https://chromium-review.googlesource.com/1088197
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564927}
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-clip-expected.png

Comment 7 by sugoi@chromium.org, Jun 6 2018

Status: Fixed (was: Unconfirmed)

Sign in to add a comment