Unnecessary focus is seen when re-auth message is shown. |
||
Issue description
What steps will reproduce the problem?
(1) Change user password during an active session and log out. Or,
append show-login-dev-overlay and click on "force online sign-
in" button.
(2) The re-auth warning is shown as expected.
(3) The drop-down menu arrow is seen focused with a blue ring.
What is the expected result?
No such focus should be seen.
The issue is also reproducible for the break time message.
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4fbb00ad9d814cbb0365762b9dd6e47806f2624 commit a4fbb00ad9d814cbb0365762b9dd6e47806f2624 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Jun 21 23:49:07 2018 cros: Move focus to tap button when showing re-auth or Bedtime messages The |tap_button_| in |LoginUserView| is responsible for handling tap events on the user view. Moving focus to the tap button when showing the messages is reasonable because 1) Tapping the user view will open the Gaia dialog, 2) It avoids the unnecessary blue ring focus. Bug: 845251 Change-Id: I522f41523750c0e1f95b7aedbdec862b3261317e Reviewed-on: https://chromium-review.googlesource.com/1111079 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569454} [modify] https://crrev.com/a4fbb00ad9d814cbb0365762b9dd6e47806f2624/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/a4fbb00ad9d814cbb0365762b9dd6e47806f2624/ash/login/ui/login_user_view.cc [modify] https://crrev.com/a4fbb00ad9d814cbb0365762b9dd6e47806f2624/ash/login/ui/login_user_view.h
,
Jun 21 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wzang@chromium.org
, May 22 2018