New issue
Advanced search Search tips

Issue 845232 link

Starred by 2 users
Status: Started
Owner:
robertma@chromium.org
Cc:
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

[WPT] Enable import notification by default (opt-in -> opt-out)

Project Member Reported by robertma@chromium.org, May 21 2018 
Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/K66A8SuHT_U

The import notifier has been running smoothly since it was launched and has provided quite some benefits with minimal spamming. Consider to enable it by default (i.e. switch from opt-out to opt-in).

Comment 1 by markdittmer@chromium.org, Aug 6 

robertma@chromium.org this issue is getting old. Shall we evaluate import reliability over, say, the last six months to make a call on this?

Comment 2 by foolip@chromium.org, Nov 13 

Ping again robertma@.

Comment 3 by robertma@chromium.org, Jan 8

Status: Started (was: Assigned)
I finally took a stab at this today.

https://chromium-review.googlesource.com/c/chromium/src/+/1401418

Patchset 1 contains the script that I used to automate the process.

150 OWNERS files have not enabled WPT-NOTIFY
66 OWNERS files have enabled WPT-NOTIFY

Although the majority of OWNERS files have not enabled notification, I think it's still worthwhile going forward to switch to opt-out, mostly to benefit any new suites in the future. It's hard to constantly remind people of the existence of an opt-in feature. WDYT?

Comment 4 by robertma@chromium.org, Jan 8 

blinkpy change to flip the default setting: https://chromium-review.googlesource.com/c/chromium/src/+/1401114
►

Sign in to add a comment