New issue
Advanced search Search tips

Issue 845227 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crash after enabling Crostini

Project Member Reported by zelidrag@chromium.org, May 21 2018

Issue description

Repro steps: Just try to enable Crostini from settings. After few minutes with the download dialog... bang! 

https://crash.corp.google.com/browse?q=reportid=%2721bd70f310b1a259%27#0

Report ID: 21bd70f310b1a259
Product, version: Chrome_ChromeOS, 68.0.3431.0
Process type: browser
Magic Signature: crostini::`anonymous namespace'::CrostiniRestarter::FinishRestart
edit bugs&comments
Stable Signaturecrostini::`anonymous namespace'::CrostiniRestarter::FinishRestart-ad0a5f9aedit bugs&comments
Report TimeSun, 20 May 2018 01:55:59 GMT
Process uptime5 min, 26 sec, 637 ms
Client ID137c6d5b770544c2b0753484f54591ff
FilesminidumpDownloadReprocess this minidump
chrome.txtDownloadView filei915_error_state.log.xzDownloadView file
In shutdownfalse
Device Modeleve-signed-mpkeys
Thread 0 (id: 17948) CRASHED [SIGSEGV @ 0x00000068 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x00005b96fd79d2a1	(chrome -scoped_refptr.h:191 )	crostini::(anonymous namespace)::CrostiniRestarter::FinishRestart(crostini::ConciergeClientResult)
0x00005b96fd79fa13	(chrome -crostini_manager.cc:282 )	crostini::(anonymous namespace)::CrostiniRestarter::StartContainerFinished(crostini::ConciergeClientResult)
0x00005b96fd79c0d4	(chrome -callback.h:96 )	crostini::CrostiniManager::OnContainerStarted(vm_tools::concierge::ContainerStartedSignal const&)
0x00005b96ff37d590	(chrome -concierge_client.cc:255 )	chromeos::ConciergeClientImpl::OnContainerStartedSignal(dbus::Signal*)
0x00005b96ff3adfa8	(chrome -callback.h:125 )	dbus::ObjectProxy::RunMethod(base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*)
0x00005b96ff3ae921	(chrome -bind_internal.h:447 )	base::internal::Invoker<base::internal::BindState<void (dbus::ObjectProxy::*)(base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*), scoped_refptr<dbus::ObjectProxy>, base::TimeTicks, std::__1::vector<base::RepeatingCallback<void (dbus::Signal*)>, std::__1::allocator<base::RepeatingCallback<void (dbus::Signal*)> > >, dbus::Signal*>, void ()>::Run(base::internal::BindStateBase*)
0x00005b96fc0876fe	(chrome -callback.h:96 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00005b96fc088c49	(chrome -incoming_task_queue.cc:124 )	base::MessageLoop::RunTask(base::PendingTask*)
0x00005b96fc089508	(chrome -message_loop.cc:329 )	base::MessageLoop::DoWork()
0x00005b96fc092407	(chrome -message_pump_libevent.cc:210 )	base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
0x00005b96fe49e4ea	(chrome -run_loop.cc:131 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x00005b96fcc682f0	(chrome -browser_main_loop.cc:978 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x00005b96fcc6b2a1	(chrome -browser_main_runner_impl.cc:169 )	content::BrowserMainRunnerImpl::Run()
0x00005b96fcc612d7	(chrome -browser_main.cc:51 )	content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >)
0x00005b96fe485d45	(chrome -content_main_runner_impl.cc:619 )	content::ContentMainRunnerImpl::Run()
0x00005b96fe490754	(chrome -main.cc:459 )	service_manager::Main(service_manager::MainParams const&)
0x00005b96fc19a957	(chrome -content_main.cc:19 )	ChromeMain
0x00007f30394f7735	(libc-2.23.so -libc-start.c:289 )	__libc_start_main
0x00005b96fc18d888	(chrome + 0x00267888 )	_start
0x00007ffca8c394a7	
 
Cc: jkardatzke@chromium.org
Owner: nverne@chromium.org
Reassigning to Nicholas since this is a crash in the Chrome concierge client code.
Labels: Proj-Containers Hotlist-Crostini-UI

Comment 3 by cmumford@google.com, May 21 2018

I'm also seeing this. I did alt-shift-i at 13:15pm (PST) if that helps find the report. 100% reproducible for me.
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88130f2e9e943a6e75babff87572b2e0ea18fc85

commit 88130f2e9e943a6e75babff87572b2e0ea18fc85
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue May 22 05:14:48 2018

Fixed a crash at the end of CrostiniInstall

The crash happened when a CrostiniRestarter callback caused the modification of
maps that were currently being iterated, invalidating assumptions of
what can be safely erased. The safe fix is to erase from the maps first,
saving the restarter objects into a temporary vector and then calling the
callbacks from iterating the vector.

Bug:  845227 
Change-Id: I64296262d1881122ec89b0083c2f29b4ea354aa9
Reviewed-on: https://chromium-review.googlesource.com/1068301
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560486}
[modify] https://crrev.com/88130f2e9e943a6e75babff87572b2e0ea18fc85/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/88130f2e9e943a6e75babff87572b2e0ea18fc85/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc

Comment 5 by nverne@chromium.org, May 22 2018

Status: Fixed (was: Assigned)

Comment 6 by vapier@chromium.org, Jun 21 2018

Components: OS>Systems>Containers

Sign in to add a comment