Align VRShell and WebXR floor heights with the user's physical floor height when known. |
|||||||||
Issue descriptionGVR provides a property on standalone headsets that can be queried to determine the offset of the user's floor from the current tracking origin: GVR_PROPERTY_TRACKING_FLOOR_HEIGHT (See: https://developers.google.com/vr/reference/android-ndk/group/types#group__types_1ggacefdb71f869a8d035d5121c5e577a8eeaf122be9c66efcfd073de59422f94e804) When this value is available we should use it to position the browser's floor grid so that it aligns with the user's physical floor as much as possible. We should also communicate this to WebXR via the "stage" frame of reference.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e44b8a89d4d887f6503ade46df6312526fca4ecc commit e44b8a89d4d887f6503ade46df6312526fca4ecc Author: Brandon Jones <bajones@chromium.org> Date: Thu May 24 23:32:13 2018 Adjust VRShell floor grid to align with users physical floor. If GVR reports a floor offset from the current tracking origin the floor grid will be adjusted to render at the same offset. This should help user comfort when using standalone devices. Bug: 845225 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I08bd081087f4f6528ec8200ee424d08f9bf9f059 Reviewed-on: https://chromium-review.googlesource.com/1067541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561690} [modify] https://crrev.com/e44b8a89d4d887f6503ade46df6312526fca4ecc/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/e44b8a89d4d887f6503ade46df6312526fca4ecc/chrome/browser/vr/model/model.h [modify] https://crrev.com/e44b8a89d4d887f6503ade46df6312526fca4ecc/chrome/browser/vr/ui.cc [modify] https://crrev.com/e44b8a89d4d887f6503ade46df6312526fca4ecc/chrome/browser/vr/ui.h [modify] https://crrev.com/e44b8a89d4d887f6503ade46df6312526fca4ecc/chrome/browser/vr/ui_scene_creator.cc
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f13b7541e314e4cb1e393d0cbb822b04a4116bfe commit f13b7541e314e4cb1e393d0cbb822b04a4116bfe Author: Brandon Jones <bajones@chromium.org> Date: Mon Jun 04 17:01:34 2018 Fix VR floor sometimes intersecting content quad Issue was caused by changing the floor grid offset but not translating the rest of the scene. Bug: 845225 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Iaeb88076af167c2ffefe60cdecd028d66946ffa5 Reviewed-on: https://chromium-review.googlesource.com/1083591 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564117} [modify] https://crrev.com/f13b7541e314e4cb1e393d0cbb822b04a4116bfe/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/f13b7541e314e4cb1e393d0cbb822b04a4116bfe/chrome/browser/vr/ui_scene_creator.cc
,
Jun 4 2018
Requesting merge of the change in comment 3 to M68, since it fixes a visual artifact that will be present in hat release otherwise.
,
Jun 4 2018
,
Jun 5 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681b6912c1b54cf062cb9e282be4388f53ce6494 commit 681b6912c1b54cf062cb9e282be4388f53ce6494 Author: Brandon Jones <bajones@chromium.org> Date: Tue Jun 05 17:21:34 2018 Fix VR floor sometimes intersecting content quad Issue was caused by changing the floor grid offset but not translating the rest of the scene. Bug: 845225 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Iaeb88076af167c2ffefe60cdecd028d66946ffa5 Reviewed-on: https://chromium-review.googlesource.com/1083591 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564117}(cherry picked from commit f13b7541e314e4cb1e393d0cbb822b04a4116bfe) Reviewed-on: https://chromium-review.googlesource.com/1087428 Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#187} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/681b6912c1b54cf062cb9e282be4388f53ce6494/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/681b6912c1b54cf062cb9e282be4388f53ce6494/chrome/browser/vr/ui_scene_creator.cc
,
Jul 4
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by cjgrant@chromium.org
, May 22 2018