"Code Review +1" button missing on merged/TBR'd changes |
|||
Issue descriptionAffected Version: 2.15.1-3832-g790d07ba47 Not sure exactly what causes this, but sometimes a change that needs my +1 doesn't have the "Code Review +1 button". This happens when the change is already merged, or when I'm TBR'd on the change (or maybe both). Changes that require my review, even if they're already landed and I'm on the TBR list, should still be reviewed by me, per Chromium's code review policy. So we should show the button to make it clear to the user that they still need to take that action.
,
May 16 2018
+cc agable, tandrii
,
May 16 2018
Michael, I think you are talking about big button at the top of the webpage, like "Code Review +1" right? If so, I agree that's annoying. Note that you can still press "A" (or click reply) and give Code-Review from the dialog box.
,
May 16 2018
Yes, that's the button. I think this matters less because it's an extra step, and more because it should be obvious that a CR+1 is expected. From a policy perspective, these changes should still be reviewed (though this isn't enforced anywhere). Hiding the CR+1 button gives the impression that no action is needed.
,
May 21 2018
,
Jan 10
Archiving issues with no priority, no component and no owner |
|||
►
Sign in to add a comment |
|||
Comment 1 by michae...@chromium.org
, May 16 2018