[MD-Refresh] Hover Buttons of the Omnibox icons look squeezed (24x26 instead of 26x26) |
||||||||||||||
Issue descriptionChrome Version: Chrome Canary 68.0.3436.0 OS: macOS 10.13.4 (but probably OS=All) What steps will reproduce the problem? (1) Enable MacViews and MD-Refresh (2) Hover over the Omnibox icons like Bookmarks Star or Zoom Button What is the expected result? The icons should be moved 1px to the left, so that the Hover Buttons can be 26x26. What happens instead? The Hover Buttons look squeezed (24x26). Screenshots are attached. Thanks Mehmet
,
May 21 2018
,
May 23 2018
bettes@ did we settle on what the desired final size for these are?
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af504d01b70d3331ab1008517fd3a48cb5fdfa04 commit af504d01b70d3331ab1008517fd3a48cb5fdfa04 Author: Peter Boström <pbos@chromium.org> Date: Wed May 23 20:20:48 2018 Add location-bar padding for newer material Adds 2dp of interior padding for Refresh and 3dp for Touchable variants which effectively adds a border to newer material layouts. This insetting ends up with 24x24dp (and fixes 24x26dp) location-bar page-action icons which fixes the inkdrop size. Prior to this the 24x24dp icons were upscaled to 26dp to match the location-bar interior height. The corresponding LOCATION_BAR_ICON_INTERIOR_PADDING value is updated for Touchable to provide a square location-bar icon, but the existing value results in a square for the updated interior padding (which is why this fixes the 24x26dp oval inkshape bug). By using even LOCATION_BAR_ELEMENT_PADDING this also accidentally fixes a tangental bug where these icons bob up and down on hover in 150% HiDPI modes. This has not yet been root caused but is seen as a nice bonus. It is not fixed for 125%, so won't mark as fixed. Corresponding screenshots of Touchable and Refresh combinations have been approved by bettes@. Bug: chromium:839148, chromium:845200 Change-Id: I68482d16decb5f8102c8cd6317ba3b0c1587e652 Reviewed-on: https://chromium-review.googlesource.com/1070367 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#561233} [modify] https://crrev.com/af504d01b70d3331ab1008517fd3a48cb5fdfa04/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/af504d01b70d3331ab1008517fd3a48cb5fdfa04/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
May 23 2018
This should be fixed now, resulting in 24x24 instead of 26x26 as the title indicates.
,
May 24 2018
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #68.0.3436.0. Verified the fix on Mac 10.13.3 using Chrome version #68.0.3439.0 as per the comment #0. Attaching screen shots for reference. Observed that icons moved 1px to the left, so that the Hover Buttons can be 24x24(as per comment #6). Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
May 24 2018
Thanks!
,
May 24 2018
Great, thanks for fixing this pbos@. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 Deleted