New issue
Advanced search Search tips

Issue 845187 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Support Windows native echo canceller

Project Member Reported by grunell@chromium.org, May 21 2018

Issue description

Add support for Windows native echo canceller - the voice capture DSP DMO.

Add it under the existing origin trial for native echo caneller available for macOS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d62ab1f7431dfec231a1f6370764de9513ac56c

commit 1d62ab1f7431dfec231a1f6370764de9513ac56c
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue May 22 17:29:23 2018

Add Windows input audio voice capture DMO for voice processing.

Controlled by existing origin trial.

Bug:  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I43e4e0d9f303086b50e9dd57ae547bfdcd79f204
Reviewed-on: https://chromium-review.googlesource.com/1065918
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560677}
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/BUILD.gn
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/audio_manager_base.h
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/mac/audio_manager_mac.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/1d62ab1f7431dfec231a1f6370764de9513ac56c/media/audio/win/core_audio_util_win.h

Should this be bumped to M69?
Status: Fixed (was: Started)
It's in M68.
Project Member

Comment 4 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2516296e113c23fb3f85141b87eeb41fcbdb0e51

commit 2516296e113c23fb3f85141b87eeb41fcbdb0e51
Author: Oskar Sundbom <ossu@chromium.org>
Date: Mon May 28 13:17:33 2018

Implement AEC output device switching for Windows

Bug:  837661 ,  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibdd94c9863d8f3f753a0cb6b033735b205d2736c
Reviewed-on: https://chromium-review.googlesource.com/1072089
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562244}
[modify] https://crrev.com/2516296e113c23fb3f85141b87eeb41fcbdb0e51/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/2516296e113c23fb3f85141b87eeb41fcbdb0e51/media/audio/win/audio_low_latency_input_win.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc298e1768ef9695387327252dada68f3c5eb91c

commit bc298e1768ef9695387327252dada68f3c5eb91c
Author: Oskar Sundbom <ossu@chromium.org>
Date: Fri Jun 01 14:37:12 2018

Merge to M68: Implement AEC output device switching for Windows

Bug:  837661 ,  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibdd94c9863d8f3f753a0cb6b033735b205d2736c
Reviewed-on: https://chromium-review.googlesource.com/1072089
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562244}(cherry picked from commit 2516296e113c23fb3f85141b87eeb41fcbdb0e51)
Reviewed-on: https://chromium-review.googlesource.com/1082551
Cr-Commit-Position: refs/branch-heads/3440@{#86}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/bc298e1768ef9695387327252dada68f3c5eb91c/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/bc298e1768ef9695387327252dada68f3c5eb91c/media/audio/win/audio_low_latency_input_win.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b67648ad60a925974ba5ec5437fe946ea269ab2a

commit b67648ad60a925974ba5ec5437fe946ea269ab2a
Author: Oskar Sundbom <ossu@chromium.org>
Date: Thu Oct 11 11:13:19 2018

Win: Remove support for the voice processing DMO echo canceller

After experimenting with it, we've decided to not move forward. As the
implementation is causing some issues, it's best to just remove it.

Bug:  888783 ,  845187 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4ef9622340266930737f9a2597c33375702f53b8
Reviewed-on: https://chromium-review.googlesource.com/c/1273069
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598722}
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/BUILD.gn
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/b67648ad60a925974ba5ec5437fe946ea269ab2a/media/audio/win/core_audio_util_win.h

Sign in to add a comment