Issue 845186 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	justincohen@chromium.org
Closed:	May 2018
Cc:	linds...@chromium.org rohitrao@chromium.org ios-bugs@chromium.org
Components:	Test>iOS
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug

Avoid flake on iPad Retina builds

Project Member Reported by justincohen@chromium.org, May 21 2018

Issue description

Apple stopped supporting iPad 32bit with Xcode 8.3.  However, running Xcode 8.2 introduces a lot of flakey test failures that does not happen on 8.3 and 9+.

Since Apple does support iPhone 32bit on 8.3, and we generally allow reduced coverage on older, much less used devices, disable the following test cases for 32bit simulator iPad:

ContentSuggestionsTestCase
SafeModeTestCase
SCContentSuggestionsTestCase
SCPaymentsEditorTestCase

Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef82a4ef1cb04b6d1276048e33fc79605576e4d7

commit ef82a4ef1cb04b6d1276048e33fc79605576e4d7
Author: Justin Cohen <justincohen@google.com>
Date: Tue May 22 20:24:47 2018

[ios] Roll iOS testers 10.0 -> 10.3.

Also disables using 'shard' e.g concurrent sharding for iOS 10.3,
and instead uses 'shard size' e.g. swarming sharding

Bug:  845186 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I9c46970d80dc08edd752d6304caeb7fb0ef2d675
Reviewed-on: https://chromium-review.googlesource.com/1067637
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560753}
[modify] https://crrev.com/ef82a4ef1cb04b6d1276048e33fc79605576e4d7/ios/build/bots/chromium.fyi/ios-simulator.json
[modify] https://crrev.com/ef82a4ef1cb04b6d1276048e33fc79605576e4d7/ios/build/bots/chromium.mac/ios-simulator-full-configs.json
[modify] https://crrev.com/ef82a4ef1cb04b6d1276048e33fc79605576e4d7/ios/build/bots/chromium.mac/ios-simulator.json

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4

commit 7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4
Author: Justin Cohen <justincohen@google.com>
Date: Tue May 22 21:18:03 2018

[ios] Disable flakey iPad Retina tests that are limited to Xcode 8.2.

Bug:  845186 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia0cd5355286b58c5c41da03ccdd61dbc1f574e22
Reviewed-on: https://chromium-review.googlesource.com/1067464
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560780}
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/chrome/browser/ui/safe_mode/BUILD.gn
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/chrome/browser/ui/safe_mode/safe_mode_egtest.mm
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/showcase/content_suggestions/BUILD.gn
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
[modify] https://crrev.com/7efa9dab6ac308eacd9fd5fbb76afd493fdbc3b4/ios/showcase/payments/sc_payments_editor_egtest.mm

Comment 3 by justincohen@chromium.org, May 22 2018

Status: Fixed (was: Assigned)

►

Issue 845186 link

Issue metadata

Avoid flake on iPad Retina builds

Issue description

Comment 1 by bugdroid1@chromium.org, May 22 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 22 2018

Comment 2 Deleted

Comment 3 by justincohen@chromium.org, May 22 2018

Comment 3 Deleted

Sign in to add a comment