New issue
Advanced search Search tips

Issue 845185 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Open links with linuxhost instead of container's IP

Project Member Reported by tbuck...@chromium.org, May 21 2018

Issue description

Chrome version: 68.0.3435.0 canary
OS: Chrome
Termina: 10685.0.0

Repro steps:
1. Run `xdg-open http://localhost:8000`

Expected: Opens a browser tab to linuxhost:8000
Actual: Opens a browser tab using my container's IP

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/70b092ad3b78cc3473c5a959de5912c9d3778111

commit 70b092ad3b78cc3473c5a959de5912c9d3778111
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Wed Jun 13 08:01:02 2018

vm_tools: concierge: Use linuxhost replacement in OpenUrl

When OpenUrl is called from garcon, and it comes from the default
container, this will replace the IP in the URL with 'linuxhost' rather
than using the IP of the container.

BUG= chromium:845185 
TEST=Verified with 'xdg-open http://localhost:8080'

Change-Id: I66a43f1873ca4e98b63a762c2e63c3b86394a09e
Reviewed-on: https://chromium-review.googlesource.com/1097420
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/70b092ad3b78cc3473c5a959de5912c9d3778111/vm_tools/cicerone/service.cc
[modify] https://crrev.com/70b092ad3b78cc3473c5a959de5912c9d3778111/vm_tools/cicerone/service.h

Status: Fixed (was: Started)

Sign in to add a comment