New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845181 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Upgrade gdk-pixbuf ebuild to upstream

Project Member Reported by bmgordon@chromium.org, May 21 2018

Issue description

Current Chrome OS version is 2.22.1.  Current upstream is 2.36.12.  The current version needs patches to work with updated versionator.eclass.  Doing the upgrade will also require upgrading (at least) eutils.eclass and gnome2-*.eclass.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/47366d42ecf8e3e763e14f45c5d2d2c590250f3f

commit 47366d42ecf8e3e763e14f45c5d2d2c590250f3f
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue May 22 19:56:24 2018

gdk-pixbuf: Explicitly inherit eutils

The new version of versionator.eclass coming in crrev.com/c/1065027 no
longer implicitly inherits eutils, but gdk-pixbuf needs functions from
it.  We should ideally upgrade gdk-pixbuf instead of patching this
ebuild, but that requires a large number of additional dependent eclass
upgrades (tracked in  crbug.com/845181 ).  Directly inherit eutils as a
temporary workaround.

BUG= chromium:845181 ,  chromium:844166 
TEST=emerge-grunt gdk-pixbuf

Change-Id: I48aa4b2bfe479cbd78e8ae744f4453cd324ebac9
Reviewed-on: https://chromium-review.googlesource.com/1066086
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/47366d42ecf8e3e763e14f45c5d2d2c590250f3f/x11-libs/gdk-pixbuf/gdk-pixbuf-2.22.1-r2.ebuild
[rename] https://crrev.com/47366d42ecf8e3e763e14f45c5d2d2c590250f3f/x11-libs/gdk-pixbuf/gdk-pixbuf-2.22.1-r5.ebuild

Cc: saludlemus@google.com vmreyes@google.com vapier@chromium.org bleung@chromium.org tbroch@chromium.org
Hi Ben,

My interns for the summer Salud and Victor (cc'd) ran into this same issue as a package they're trying to bring in depends on the upstream version of gdk-pixbuf too.

Do you have a list of known upgrades that could help unblock them?
I'm back from leave now.  Do you still need a list?  When I looked at this before, I believe I started with gnome2.eclass and just started tracing what broke.
Hello, Salud and I have been trying to incorporate FWUPD into Chrome OS crbug.com/857263. 
FWUPD depends on the upstream version of gdk-pixbuf. Salud and I were able to get gdk-pixbuf to emerge onto eve with the following CLs:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1145557
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1145556

However, it seems that the package needs more patches (or maybe any local patches) to get to work. When the package is loaded onto a board, gdk-pixbuf-query-loaders gives the following warning: 
g_module_open() failed for /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-bmp.so: /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-bmp.so: undefined symbol: gdk_pixbuf_calculate_rowstride
Did you put it on with cros deploy or by building an image?  That looks like the sort of error that might come from needing to rebuild a dependent package.
Correct, I used cros deploy. What packages should I rebuild?
Owner: timzheng@chromium.org
Status: Fixed (was: Available)
This was completed in https://crrev.com/c/1345476

Sign in to add a comment