"NotificationHelperLaunchesChrome.ChromeLaunchTest" is flaky |
|||||
Issue description"NotificationHelperLaunchesChrome.ChromeLaunchTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFOb3RpZmljYXRpb25IZWxwZXJMYXVuY2hlc0Nocm9tZS5DaHJvbWVMYXVuY2hUZXN0DA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 841475 .
,
May 22 2018
Fix in review. https://chromium-review.googlesource.com/c/chromium/src/+/1068968
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d177c06ea367e81a95deedbf346084ab50084a1 commit 4d177c06ea367e81a95deedbf346084ab50084a1 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Tue May 22 16:07:54 2018 Win Native Notifications: Deflake activation test. Bug: 845176 , 734095 Change-Id: Ia826226aa8fe509c0f2d7a80a106b5a60d293528 Reviewed-on: https://chromium-review.googlesource.com/1068968 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#560625} [modify] https://crrev.com/4d177c06ea367e81a95deedbf346084ab50084a1/chrome/browser/notifications/notification_helper_launches_chrome_unittest.cc
,
May 22 2018
Detected 6 new flakes for test/step "NotificationHelperLaunchesChrome.ChromeLaunchTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFOb3RpZmljYXRpb25IZWxwZXJMYXVuY2hlc0Nocm9tZS5DaHJvbWVMYXVuY2hUZXN0DA. This message was posted automatically by the chromium-try-flakes app.
,
May 22 2018
,
May 22 2018
,
May 23 2018
The flakes reported after my checkin are from the old code (pre-fix). Marking as fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by calamity@chromium.org
, May 22 2018Status: Assigned (was: Untriaged)