New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845174 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Migrate builder chroot setup into cbuildbot_launch

Project Member Reported by bmgordon@chromium.org, May 21 2018

Issue description

chroot handling is currently spread around between a bunch of stages in cbuildbot_launch, cbuildbot, and calls into cros_sdk.

Design proposal to unify a bunch of this into cbuildbot_launch is at go/cros-pristine-chroot
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a43af0e6e60df64c04221a78aa919c0930a16c6c

commit a43af0e6e60df64c04221a78aa919c0930a16c6c
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 23 04:57:07 2018

chroot_lib: Remove ChrootManager

This was originally added in crrev.com/c/224852 to support incremental
builds by detecting local build failures.  This functionality has been
replaced by a more robust implementation, so the LKGM-based method is
now counterproductive.  Also remove the entire chroot_lib module, since
there aren't any other users of it.

BUG=chromium:845174
TEST=master-paladin and grunt-paladin tryjobs

Change-Id: I48ad562cf9a41b29d0cf08f4900c1db5c58fa796
Reviewed-on: https://chromium-review.googlesource.com/1067444
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[delete] https://crrev.com/4faa3c74a4e02bea4a40c28beee56b4adc572eea/cbuildbot/chroot_lib_unittest
[modify] https://crrev.com/a43af0e6e60df64c04221a78aa919c0930a16c6c/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/a43af0e6e60df64c04221a78aa919c0930a16c6c/cbuildbot/stages/sync_stages.py
[delete] https://crrev.com/4faa3c74a4e02bea4a40c28beee56b4adc572eea/cbuildbot/chroot_lib.py
[modify] https://crrev.com/a43af0e6e60df64c04221a78aa919c0930a16c6c/cbuildbot/stages/build_stages.py
[delete] https://crrev.com/4faa3c74a4e02bea4a40c28beee56b4adc572eea/cbuildbot/chroot_lib_unittest.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d9c0f04b870d604359890237495d1ac5091c740

commit 8d9c0f04b870d604359890237495d1ac5091c740
Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 23 07:13:03 2018

Roll src/third_party/chromite/ 07dfd789c..fdd7e08cd (5 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/07dfd789cb28..fdd7e08cde5d

$ git log 07dfd789c..fdd7e08cd --date=short --no-merges --format='%ad %ae %s'
2018-05-21 yunlian cros_gdb: support simple chrome
2018-05-21 bmgordon chroot_lib: Remove ChrootManager
2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _LoggingSink
2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _AtestSource
2018-05-21 ayatane sysmon: Refactor prod_metrics: Remove _ProdHostReporter

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:843275 ,chromium:845174,chromium:None,chromium:None,chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I32201b36652a22d6f98c4c470ae1319206badc92
Reviewed-on: https://chromium-review.googlesource.com/1069979
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560986}
[modify] https://crrev.com/8d9c0f04b870d604359890237495d1ac5091c740/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/be4851634cd86141497b4878a634481956cbe57d

commit be4851634cd86141497b4878a634481956cbe57d
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue Jun 05 00:23:26 2018

make_chroot: Remove unused toolchain overlay support

cros_sdk can pass in an additional overlay tarball to unpack on top of
the chroot.  This hasn't been used in cros_sdk since 2016 and is being
removed, so no need to support it in make_chroot.sh, either.

BUG=chromium:845174
TEST=cros_sdk --create
CQ-DEPEND=CL:1081389

Change-Id: I1f585fd5f2d0991c43b804f30d34c2a0a68337a6
Reviewed-on: https://chromium-review.googlesource.com/1081339
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/be4851634cd86141497b4878a634481956cbe57d/sdk_lib/make_chroot.sh

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/589873ba61e70cbc7a8be05ee5b77b5cbc1b35bb

commit 589873ba61e70cbc7a8be05ee5b77b5cbc1b35bb
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue Jun 05 00:23:26 2018

cros_sdk: Remove unused toolchain overlay support

The --toolchains argument downloads additional tarball(s) and unpacks
them on top of the initial extracted chroot.  The --board argument
preselects toolchains for a particular board and then works the same as
--toolchains.  Both of these are looking for files that were turned off
in March 2016 (see crrev.com/c/332862).  Nobody has complained about the
lack since then, so let's just remove this code.

BUG=chromium:845174
TEST=cros_sdk --create

Change-Id: I78bad27d211521f1e3ffb30bc7a8263d48639ff8
Reviewed-on: https://chromium-review.googlesource.com/1081389
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/589873ba61e70cbc7a8be05ee5b77b5cbc1b35bb/scripts/cros_sdk.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7

commit 7cc6e786d406aea1df1526cbe9c65b4e15afb8a7
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 05 01:55:33 2018

Roll src/third_party/chromite 9665e37..84e4547 (6 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9665e37..84e4547


git log 9665e37..84e4547 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 dhanyaganesh@google.com 'tar: file changed as we read it' fix
2018-06-05 ayatane@chromium.org chromeos-infra-go-pre-cq: New build config
2018-06-05 dgarrett@google.com config_stages: Handle multiple config locations.
2018-06-05 ahassani@chromium.org paygen: Rename signature variables
2018-06-05 bmgordon@chromium.org cros_sdk: Remove unused toolchain overlay support
2018-06-05 dats@google.com cros-disks: FUSE daemons are not in chronos-access anymore.


Created with:
  gclient setdep -r src/third_party/chromite@84e4547

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:547055,chromium:845337, chromium:848020 , chromium:845614 ,chromium:845174, chromium:841119 
TBR=chrome-os-gardeners@chromium.org

Change-Id: I04ea4de88cd62923087594cce649f787b3b251b4
Reviewed-on: https://chromium-review.googlesource.com/1086328
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564344}
[modify] https://crrev.com/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7/DEPS

Labels: -Pri-2 Pri-3
Lowering priority since the remaining work is likely to wait for an intern this summer.

Sign in to add a comment