Squad: don't reattach object/image fallback content as part of layout tree building |
||
Issue descriptionWe currently trigger e.g. image loading as part of layout tree attachment. If we immediately get a loading failure, we reattach the sub-tree to display fallback content immediately. That means the ComputedStyle will be nuked and recomputed from LayoutTreeBuilder, at least for the re-attach root.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5b29d04b62d0f95e373dac8fb263b3148d19d9a commit f5b29d04b62d0f95e373dac8fb263b3148d19d9a Author: Rune Lillesveen <futhark@chromium.org> Date: Tue May 29 05:07:59 2018 [Squad] Trigger image loading on style recalc for plugins. This is done to avoid re-attaching fallback content as part of building the layout tree. That meant we had to recalculate style twice, the second time inside LayoutTreeBuilderForElement::Style(). TEST=http/tests/misc/object-image-error.html Bug: 843520 , 845167 Change-Id: I5ad8d0f5d82a6ef0437d6ef5e1e015f5e1575faa Reviewed-on: https://chromium-review.googlesource.com/1073421 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562341} [modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_object_element.cc [modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_plugin_element.cc [modify] https://crrev.com/f5b29d04b62d0f95e373dac8fb263b3148d19d9a/third_party/blink/renderer/core/html/html_plugin_element.h
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/810bb17f22970b02ca6f050afaf9a2c8bcb5beb3 commit 810bb17f22970b02ca6f050afaf9a2c8bcb5beb3 Author: Rune Lillesveen <futhark@chromium.org> Date: Wed May 30 05:25:44 2018 [Squad] SetLayoutDisposition() not called during style update. I have not been able to find a situation where we would call SetLayoutDisposition() during style or layout tree update. Replacing the synchronous re-attach code with a DCHECK. Bug: 843520 , 845167 Change-Id: Ibf1e8a02d0e905522e4006be078b047b6a856b8a Reviewed-on: https://chromium-review.googlesource.com/1076027 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562742} [modify] https://crrev.com/810bb17f22970b02ca6f050afaf9a2c8bcb5beb3/third_party/blink/renderer/core/html/html_image_element.cc
,
May 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 28 2018