MaybeSetupAlternateStack() in abseil is unused and is suddenly breaking some builds |
||
Issue descriptionThe windows jumbo build bot broke suddenly with this error: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 [5457/12480] CXX obj/third_party/abseil-cpp/absl/debugging/failure_signal_handler/failure_signal_handler.obj FAILED: obj/third_party/abseil-cpp/absl/debugging/failure_signal_handler/failure_signal_handler.obj ... ../../third_party/abseil-cpp/absl/debugging/failure_signal_handler.cc(164,12): error: unused function 'MaybeSetupAlternateStack' [-Werror,-Wunused-function] static int MaybeSetupAlternateStack() { ^ 1 error generated. The only change was a webrtc roll so I don't know why it triggered but it's true, the function is unused.
,
May 21 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/8436a699a998e4fa30d97786142baad08f110d2a commit 8436a699a998e4fa30d97786142baad08f110d2a Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Mon May 21 14:38:36 2018 Revert "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 Original change's description: > Reland "Adding absl includes and defines to rtc_* templates." > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > Reason for revert: The new version of Abseil should fix the previous > issue. > > Original change's description: > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > Original change's description: > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > Original change's description: > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > Original change's description: > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > it because it creates problems with other build systems. Given this > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > in their public_deps will propagate these configs following the GN > > > > > guideline. > > > > > > > > > > Bug: webrtc:8821 > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: webrtc:8821 > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Bug: webrtc:8821 > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:8821 > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23264} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: webrtc:8821 > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > Reviewed-on: https://webrtc-review.googlesource.com/77781 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23317} TBR=phoglund@webrtc.org,mbonadei@webrtc.org Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8821, chromium:845158 Reviewed-on: https://webrtc-review.googlesource.com/78061 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23328} [modify] https://crrev.com/8436a699a998e4fa30d97786142baad08f110d2a/webrtc.gni
,
May 21 2018
Do you have any idea about why it only fails on a jumbo build?
,
May 21 2018
No idea why not more bots react. Maybe they will eventually. I could reproduce locally without jumbo enabled (with an empty args.gn), just building > ninja -C out\Release failure_signal_handler My best guess is that very few bots build "all".
,
May 21 2018
Yeah, that is probably why. Thanks.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349158ec7d7da1de29628c682e1b26a476e6381d commit 349158ec7d7da1de29628c682e1b26a476e6381d Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 23 15:38:33 2018 Roll src/third_party/webrtc/ a832019f4..547e3169d (45 commits) https://webrtc.googlesource.com/src.git/+log/a832019f4e3a..547e3169d9e0 $ git log a832019f4..547e3169d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:813328 , chromium:845135 ,chromium:none,chromium:841962,chromium:888042,chromium:None,chromium:845158,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d118a77cf2b61247d8720d3c9b93091416454a9 Reviewed-on: https://chromium-review.googlesource.com/1070209 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561102} [modify] https://crrev.com/349158ec7d7da1de29628c682e1b26a476e6381d/DEPS
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64f301b2de6e1c57fe57db3a56ffabda0cd8960b commit 64f301b2de6e1c57fe57db3a56ffabda0cd8960b Author: Mirko Bonadei <mbonadei@chromium.org> Date: Thu May 24 11:25:56 2018 Roll abseil_revision 30de20488b..014f02a3ec. Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/30de20488b..014f02a3ec Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/30de20488b..014f02a3ec Bug: 845158 Change-Id: Ife1d55b8fb44493de01446ee8781dee35a8ccd23 Reviewed-on: https://chromium-review.googlesource.com/1071468 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561462} [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/CMakeLists.txt [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/README.chromium [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/base/BUILD.bazel [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/base/BUILD.gn [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/base/CMakeLists.txt [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/base/dynamic_annotations.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/base/internal/hide_ptr.h [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/debugging/failure_signal_handler.cc [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/memory/memory.h [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/numeric/BUILD.bazel [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/BUILD.bazel [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/numbers.h [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/str_cat_benchmark.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/str_join_benchmark.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/str_replace_benchmark.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/str_split_benchmark.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/strings/string_view_benchmark.cc [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/BUILD.bazel [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/BUILD.gn [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/internal/graphcycles.cc [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/internal/graphcycles_benchmark.cc [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/mutex.cc [modify] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/mutex.h [add] https://crrev.com/64f301b2de6e1c57fe57db3a56ffabda0cd8960b/third_party/abseil-cpp/absl/synchronization/mutex_benchmark.cc
,
May 24 2018
,
May 28 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/fae51e4c95780f59f4bedf6e01403ff86152e168 commit fae51e4c95780f59f4bedf6e01403ff86152e168 Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Mon May 28 07:49:09 2018 Reland "Adding absl includes and defines to rtc_* templates." This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. Reason for revert: New absl roll -> https://chromium-review.googlesource.com/1071468 Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > Reason for revert: The new version of Abseil should fix the previous > > issue. > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > Original change's description: > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > Original change's description: > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > it because it creates problems with other build systems. Given this > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > in their public_deps will propagate these configs following the GN > > > > > > guideline. > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821 > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821 > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23317} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/78061 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23328} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 Reviewed-on: https://webrtc-review.googlesource.com/78705 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23403} [modify] https://crrev.com/fae51e4c95780f59f4bedf6e01403ff86152e168/webrtc.gni
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0257046a7d6014205c898f17079f091eccae8f27 commit 0257046a7d6014205c898f17079f091eccae8f27 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 28 13:22:12 2018 Roll src/third_party/webrtc/ b3085b288..dacec71b1 (5 commits) https://webrtc.googlesource.com/src.git/+log/b3085b288b17..dacec71b1627 $ git log b3085b288..dacec71b1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:845158 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I560983d78bb21759aa46d7e3ac1d9a604d6d419e Reviewed-on: https://chromium-review.googlesource.com/1074453 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562246} [modify] https://crrev.com/0257046a7d6014205c898f17079f091eccae8f27/DEPS
,
May 28 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933 commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933 Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Mon May 28 13:43:40 2018 Revert "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. Reason for revert: When use_xcode_clang = true we get: error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] Original change's description: > Reland "Adding absl includes and defines to rtc_* templates." > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > Reason for revert: > New absl roll -> https://chromium-review.googlesource.com/1071468 > > Original change's description: > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > Original change's description: > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > issue. > > > > > > Original change's description: > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > Original change's description: > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > Original change's description: > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > Original change's description: > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > guideline. > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > No-Presubmit: true > > > > > > No-Tree-Checks: true > > > > > > No-Try: true > > > > > > Bug: webrtc:8821 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Bug: webrtc:8821 > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: webrtc:8821 > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: webrtc:8821 > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:8821, chromium:845158 > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23328} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: webrtc:8821, chromium:845158 > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > Reviewed-on: https://webrtc-review.googlesource.com/78705 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23403} TBR=phoglund@webrtc.org,mbonadei@webrtc.org Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8821, chromium:845158 Reviewed-on: https://webrtc-review.googlesource.com/79420 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23416} [modify] https://crrev.com/759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933/webrtc.gni
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/316df9add71ee84385b702f002fef1bda7ceda7b commit 316df9add71ee84385b702f002fef1bda7ceda7b Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 29 13:04:26 2018 Roll src/third_party/webrtc/ b3085b288..2aae2733a (23 commits) https://webrtc.googlesource.com/src.git/+log/b3085b288b17..2aae2733a70c $ git log b3085b288..2aae2733a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:844647,chromium:845158,chromium:794608,chromium:None,chromium:None,chromium:None,chromium:845158 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a13060bf81727a06eb046ff9c6ef9b18b4a9876 Reviewed-on: https://chromium-review.googlesource.com/1075864 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562399} [modify] https://crrev.com/316df9add71ee84385b702f002fef1bda7ceda7b/DEPS
,
May 29 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/9a89a491f801afb2a4fb0d90be397a4b2e553a95 commit 9a89a491f801afb2a4fb0d90be397a4b2e553a95 Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Tue May 29 15:17:04 2018 Reland "Reland "Adding absl includes and defines to rtc_* templates."" This reverts commit 759eb4f2ad7e23b65fe0b834f8ba7f580bf1a933. Reason for revert: The problem has been fixed in https://chromium-review.googlesource.com/1075889. Original change's description: > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > This reverts commit fae51e4c95780f59f4bedf6e01403ff86152e168. > > Reason for revert: > When use_xcode_clang = true we get: > error: unknown warning option '-Wno-unused-template'; did you mean '-Wno-unused-result'? [-Werror,-Wunknown-warning-option] > error: unknown warning option '-Wno-zero-as-null-pointer-constant'; did you mean '-Wno-int-to-void-pointer-cast'? [-Werror,-Wunknown-warning-option] > > > Original change's description: > > Reland "Adding absl includes and defines to rtc_* templates." > > > > This reverts commit 8436a699a998e4fa30d97786142baad08f110d2a. > > > > Reason for revert: > > New absl roll -> https://chromium-review.googlesource.com/1071468 > > > > Original change's description: > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > This reverts commit bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5. > > > > > > Reason for revert: https://ci.chromium.org/buildbot/chromium.fyi/Jumbo%20Win%20x64/11502 > > > > > > Original change's description: > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > This reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f. > > > > > > > > Reason for revert: The new version of Abseil should fix the previous > > > > issue. > > > > > > > > Original change's description: > > > > > Revert "Reland "Adding absl includes and defines to rtc_* templates."" > > > > > > > > > > This reverts commit 9632112a16d70a146e917db4de761e6253dfc364. > > > > > > > > > > Reason for revert: It breaks the WebRTC roll into Chromium. > > > > > https://chromium-review.googlesource.com/c/chromium/src/+/1061476 > > > > > > > > > > Original change's description: > > > > > > Reland "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8. > > > > > > > > > > > > Reason for revert: The problem with iOS trybots should be fixed. > > > > > > > > > > > > Original change's description: > > > > > > > Revert "Adding absl includes and defines to rtc_* templates." > > > > > > > > > > > > > > This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c. > > > > > > > > > > > > > > Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793. > > > > > > > > > > > > > > Original change's description: > > > > > > > > Adding absl includes and defines to rtc_* templates. > > > > > > > > > > > > > > > > This CL implicitly adds the -I compiler flag and absl macros to WebRTC > > > > > > > > templates. In order to include absl headers using relative paths, WebRTC > > > > > > > > needs to ensure that all its build targets are able to see absl headers. > > > > > > > > > > > > > > > > This can also be done with public_deps, but WebRTC is trying to avoid > > > > > > > > it because it creates problems with other build systems. Given this > > > > > > > > constraint, using rtc_* templates is the most reliable solution. > > > > > > > > > > > > > > > > Please note that rtc_* templates are adding absl includes and defines > > > > > > > > as public_configs, this means that build targets with WebRTC targets > > > > > > > > in their public_deps will propagate these configs following the GN > > > > > > > > guideline. > > > > > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > > > Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7 > > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/70367 > > > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > > Cr-Commit-Position: refs/heads/master@{#22927} > > > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > > > Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37 > > > > > > > No-Presubmit: true > > > > > > > No-Tree-Checks: true > > > > > > > No-Try: true > > > > > > > Bug: webrtc:8821 > > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71000 > > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > > Cr-Commit-Position: refs/heads/master@{#22928} > > > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > > > Bug: webrtc:8821 > > > > > > Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8 > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/71700 > > > > > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org> > > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#23251} > > > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > > > Change-Id: I61fb749797314ca514691b341c66f7f39ef45491 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: webrtc:8821 > > > > > Reviewed-on: https://webrtc-review.googlesource.com/77220 > > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > > Cr-Commit-Position: refs/heads/master@{#23264} > > > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: webrtc:8821 > > > > Change-Id: I71dea953a002a0d526949c627653bcad0c6518fc > > > > Reviewed-on: https://webrtc-review.googlesource.com/77781 > > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#23317} > > > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > > > Change-Id: I6010f9264dba7bcc4e82c4f4bbfb2eca561e500e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:8821, chromium:845158 > > > Reviewed-on: https://webrtc-review.googlesource.com/78061 > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#23328} > > > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: webrtc:8821, chromium:845158 > > Change-Id: Iebe0958012c39e1321487e5425f43904eaf5fe91 > > Reviewed-on: https://webrtc-review.googlesource.com/78705 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23403} > > TBR=phoglund@webrtc.org,mbonadei@webrtc.org > > Change-Id: I8285cf59402aa6862ea7e3ec21f885360b7050fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8821, chromium:845158 > Reviewed-on: https://webrtc-review.googlesource.com/79420 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23416} TBR=phoglund@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8821, chromium:845158 Change-Id: I18ffdb0d7be61daf0b6464c68d219aa352f42dde Reviewed-on: https://webrtc-review.googlesource.com/79582 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23435} [modify] https://crrev.com/9a89a491f801afb2a4fb0d90be397a4b2e553a95/webrtc.gni
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fafa829ccd4f21846a752014d05c746a2b685d5 commit 1fafa829ccd4f21846a752014d05c746a2b685d5 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 29 18:57:58 2018 Roll src/third_party/webrtc 7a0bb00..9a89a49 (3 commits) https://webrtc.googlesource.com/src.git/+log/7a0bb00..9a89a49 git log 7a0bb00..9a89a49 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 mbonadei@webrtc.org Reland "Reland "Adding absl includes and defines to rtc_* templates."" 2018-05-29 henrika@webrtc.org Thread checker fails when switching to/from bluetooth headset. 2018-05-29 buildbot@webrtc.org Roll chromium_revision 04484f1ad8..eb7233cee8 (562301:562409) Created with: gclient setdep -r src/third_party/webrtc@9a89a49 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:845158 ,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc93ff67e5dd4c965ccb5d1f605963b4a1017057 Reviewed-on: https://chromium-review.googlesource.com/1076678 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562530} [modify] https://crrev.com/1fafa829ccd4f21846a752014d05c746a2b685d5/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by mbonadei@chromium.org
, May 21 2018Owner: mbonadei@chromium.org
Status: Started (was: Untriaged)