virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html times out |
||||||
Issue descriptionThis is the same as running external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html with RTCConfiguration sdpSemantics:"unified-plan". While Unified Plan will not be fully supported until we have transceivers ( https://crbug.com/777617 ), these spec compliant tests are Plan B compatible and should not time out when sdpSemantics:"unified-plan" is used, that would be a regression. Most likely some event is not firing, investigate before the cut.
,
May 21 2018
,
May 21 2018
NextAction set to tomorrow, if I haven't gotten around to it by then me or you can take it on.
,
May 21 2018
Reproducing it from the command line: out/Default/content_shell --enable-blink-features=RTCUnifiedPlanByDefault --run-layout-test third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html This hangs before producing any FAIL or PASS messages.
,
May 22 2018
That is expected, it will only produce the FAIL/PASS messages at the end upon completing all tests. Even if it completes all but the last test it will not produce any FAIL/PASS messages. Commenting out individual tests is a good way to determine what test(s) time out.
,
May 22 2018
console.log and printf works too, separate from FAIL/PASS lines.
,
May 22 2018
The NextAction date has arrived: 2018-05-22
,
May 24 2018
Lowering the priority because other testing (of real applications) is positive and the M68 cut is today. This should still be investigated though. I'll be OOO for a few days.
,
May 27 2018
Spent a little time doing printf debugging. One problem is this test: 'addTrack() with a track and two streams makes ontrack fire with a track and two streams.' The function makes the name "performOffer" do double duty. Can be fixed in the test. This test: 'removeTrack() makes stream.onremovetrack fire and the track to be removed from the stream.' gets to the addTrack event, but not the removeTrack event.
,
May 30 2018
Oh okay, that makes sense, probably that since receivers are no longer removed the plumbing does not work correctly. The code path needs to be updated for "transceiver's direction changed, it is inactive so remove tracks from streams". This will all naturally be fixed with transceivers.
,
May 30 2018
We won't fix this separately from transceivers I don't think, so I'm marking it as "started" since I'm working on transcievers.
,
Aug 21
We have transceivers now ( https://crbug.com/777617 ) and in Unified Plan this no longer times out, in fact it PASSes every single test: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt?q=RTCPeerConnection-setRemoteDescription-tracks.https&sq=package:chromium&dr Fixed in M69. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hbos@chromium.org
, May 21 2018