Issue metadata
Sign in to add a comment
|
PdfAccessibilityTreeTest.TestEmptyPDFPage fails on msan |
||||||||||||||||||||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/936454 added fields to PP_PrivateAccessibilityViewportInfo but didn't set them in all places that instantiate this struct: https://cs.chromium.org/search/?q=PP_PrivateAccessibilityViewportInfo%5B%5E)%5D*;&sq=package:chromium&type=cs In particular, PdfAccessibilityTreeTest never initializes these fields, leading to an msan report when I try and add components_browsertests to the msan bot: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTLinuxMSan%2F2543%2F%2B%2Frecipes%2Fsteps%2Fcomponents_browsertests%2F0%2Flogs%2FPdfAccessibilityTreeTest.TestEmptyPDFPage%2F0 Can you take a look? It just requires initializing these fields in the test, but I'm not sure what they need to be set to.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/296bd05553a2a4386b048be57e12dbecfd1bd849 commit 296bd05553a2a4386b048be57e12dbecfd1bd849 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu May 24 17:07:24 2018 Initialize some struct members in a test to fix MSAN failure. Bug: 845143 , 843511 Change-Id: I87afc7235692c52502048dcf7ae6036ae8551e51 Reviewed-on: https://chromium-review.googlesource.com/1067491 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561533} [modify] https://crrev.com/296bd05553a2a4386b048be57e12dbecfd1bd849/components/pdf/renderer/OWNERS [modify] https://crrev.com/296bd05553a2a4386b048be57e12dbecfd1bd849/components/pdf/renderer/pdf_accessibility_tree_browsertest.cc
,
May 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, May 21 2018