Prettify JSON in logdog |
|||
Issue descriptionhttps://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Flinux-perf%2F92%2F%2B%2FBenchmarks_Logs_4611c0fa-8126-40d5-9b6d-d7fee08d893c is an example logdog file that contains the links to our perf benchmark logs. The page is a bit hard to use. Beside linkinfy the urls ( issue 844434 ) Would be great if we can make the page render a bit nicer (maybe add color?)
,
May 21 2018
I'm kinda torn about allowing tools to specify the content-type, I see this as an attack vector.
,
May 25 2018
Note that LogDog already supports user-defined content type
,
May 25 2018
nodir@: how do I specify the content type? Currently I use logdog_helper.text(..) to upload to logdog (https://cs.chromium.org/chromium/src/tools/perf/process_perf_results.py?rcl=5b8466d84c801a9dfe140cb9a9f6be3a8caba230&l=164)
,
May 25 2018
(with some code grepping) please add content_type param in logdog https://cs.chromium.org/chromium/src/build/android/pylib/utils/logdog_helper.py?q=logdog_helper&dr&rcl=9efa729c382c00ae0746a4abf98e4358d9f12ff4&l=22 and pass it to get_logdog_client().text(name) see https://cs.chromium.org/chromium/infra/luci/client/libs/logdog/stream.py?type=cs&q=package:%5E(chromium)$+file:(/%7C%5E)libs/logdog(%5C.(swig%7Cpy%7Cspt)$%7C/(__init__%5C.(swig%7Cpy%7Cspt))?$)&g=0&l=356 and https://cs.chromium.org/chromium/infra/luci/client/libs/logdog/stream.py?type=cs&q=package:%5E(chromium)$+file:(/%7C%5E)libs/logdog(%5C.(swig%7Cpy%7Cspt)$%7C/(__init__%5C.(swig%7Cpy%7Cspt))?$)&g=0&l=386
,
May 25 2018
CL to plumb content type: https://chromium-review.googlesource.com/c/chromium/src/+/1073390 If possible, I think it would be great to make lodog prettify json if it detects the content has json type. THe reason is any extra step we ask sheriff to do (install Chrome extension in this case), the harder it would be for everyone to follow through it.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/995c023528749c4f40c49150f31bd1c4ca59de61 commit 995c023528749c4f40c49150f31bd1c4ca59de61 Author: nednguyen <nednguyen@google.com> Date: Fri May 25 15:20:15 2018 Set json content type for perf's logdog pages that display json content TBR=jbudorick@chromium.org Bug: 845139 Change-Id: I293032217af574b8980defb5142e2b21c1a1517f Reviewed-on: https://chromium-review.googlesource.com/1073390 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Emily Hanley <eyaich@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#561883} [modify] https://crrev.com/995c023528749c4f40c49150f31bd1c4ca59de61/build/android/pylib/utils/logdog_helper.py [modify] https://crrev.com/995c023528749c4f40c49150f31bd1c4ca59de61/tools/perf/process_perf_results.py
,
May 29 2018
Nodir: even with the extension enabled and the change in #7, I still don't see the prettified JSON in https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Flinux-perf%2F135%2F%2B%2FBenchmarks_Logs_32077835-ffb6-4c9a-993a-fd1097ae3f91 Can you let me know if something is missing?
,
May 29 2018
Custom content-type is supported in another endpoint that isn't quite ready yet. ETA: EOQ |
|||
►
Sign in to add a comment |
|||
Comment 1 by hinoka@chromium.org
, May 21 2018