Network.disable is not sent when network inspection is turned off
Reported by
ing...@cloudflare.com,
May 21 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0 Steps to reproduce the problem: 1. Open Network tab in devtools (with recording on, as it is by default). 2. Open Protocol Inspector. 3. Disable network logging. What is the expected behavior? Network.disable CDP command is sent to the inspector server so that it can stop intercepting requests, storing responses for potential Network.getResponseBody calls and so on. What went wrong? Network.disable is not sent so backend has no way of knowing that inspector frontend is no longer interested in / subscribed to Network events and that there is no point in intercepting and storing the corresponding data. Did this work before? N/A Chrome version: 68.0.3436.0 Channel: canary OS Version: OS X 10.13 Flash Version:
,
May 21 2018
Mostly just a performance concern (especially memory one, since getResponseBody requires keeping body pretty much indefinitely until the client disconnects) for non-Chrome backends. Can you elaborate please what's the point to continue monitoring if client is not subscribed to these new requests and won't show them anyway?
,
May 21 2018
,
May 23 2018
As per comment#1 cc'ing dgozman@ for further inputs on this. Could you please check comment#2 and help in triaging this. Thanks!
,
May 25 2018
- If the request was started before user pressed "stop", we keep getting updates for it and update that request in UI (e.g. showing new timing). - We continue to apply any modifications even when user is not recording, e.g. user agent override, interceptions, url blocking, throttling, etc. We can make storing requests data optional during this time, but it never was a concern, and it will require a command separate from disable. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dgozman@chromium.org
, May 21 2018