New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845126 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 843963
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Font size of 'IP address', etc increases after disabling 'Configure IP address automatically' in Network details dialog in login screen

Project Member Reported by mmanchala@chromium.org, May 21 2018

Issue description

Chrome Version:  68.0.3436.0/10700.0.0 dev-channel Paine,Kip and Peppy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Sign-out from Uber Tray 
(2)In Sign-out screen at Uber Tray select 'Network' option -> click on 'Network settings' icon 
->'Network settings' window is seen
(3)Disable 'Configure IP address automatically' option and observe increase in font size of 'IP address','Routing prefix' & 'Gateway' details
(Please refer video and screenshot)

Note :  Issue 843963  is seen fixed in 68.0.3436.0/10700.0.0 i.e. increase in font size is not seen for 'IP address','Routing prefix' & 'Gateway' details under 'Network' in connected Wi-Fi network details of chrome://settings page
(Please refer 'FontIsNormalInSettingsPage)

Expected: Increase in font size should not be seen for 'IP address','Routing prefix' & 'Gateway' details
Actual: Instead increase in font size is seen for 'IP address','Routing prefix' & 'Gateway' details
 
This is Regression issue as same is working fine in 68.0.3423.0/10661.0.0  dev-channel Paine

@stevenjb: Please confirm the Issue
 
Actual_Font.mp4
17.0 MB Download
Actual_Font.jpg
743 KB View Download
FontIsNormalInSettingsPage.webm
846 KB View Download
Attaching Expected video and Screenshot for reference 
Expected_Font.mp4
15.1 MB Download
Expected_Font.jpg
711 KB View Download
Mergedinto: 843963
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
Able to repro the issue on latest M-68 68.0.3438.0/10710.0.0 dev-channel whereas  Issue 843963   is seen fixed in 68.0.3438.0/10710.0.0 & 68.0.3436.0/10700.0.0

Reopening this issue for confirmation

Thanks..!! 
Why was this re-opened instead of  issue 843963 ? Can this be reproduced but not that? (The repros look identical, am I missing something?)


Status: Started (was: Assigned)
Summary: Regression : Font size of 'IP address', etc increases after disabling 'Configure IP address automatically' in Network details dialog in login screen (was: Regression : Font size of 'IP address','Routing prefix' & 'Gateway' details increases after disabling 'Configure IP address automatically' option in Network settings' page)
Oh. I see. The description does not match the repro (it says 'Network Settings', but t repro is in the network details dialog triggered from the system tray in the login screen). Updating the summary.

Status: Fixed (was: Started)
Delete comment ⚐
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48ab25f7683632b99e21ba42b0f6e29b85857bef

commit 48ab25f7683632b99e21ba42b0f6e29b85857bef
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri May 25 01:18:30 2018

Fix internet dialog styling for Polymer2

This moves the paper-input-container styling to the network components
so that it applies consistently in Settings and in dialogs.

It also includes some other minor fixes and adds styling to each
dialog to match Settings (primarily for line-height).

Bug:   844259  
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice417ced7cd3758c8270cfc00a221aa4b15fe466
Reviewed-on: https://chromium-review.googlesource.com/1072235
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561722}
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/settings/internet_page/internet_shared_css.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html
[modify] https://crrev.com/48ab25f7683632b99e21ba42b0f6e29b85857bef/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
Labels: ReleaseBlock-Stable Merge-Request-68
Minor issue, but visually jarring. Fix is simple/straightforward and CrOS only.

Project Member

Comment 8 by sheriffbot@chromium.org, May 26 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, May 29 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-68
This actually just made it in, no need to merge.

Sign in to add a comment