New issue
Advanced search Search tips

Issue 845124 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1% improvement in memory.top_10_mobile at 1525384500:1525395988

Project Member Reported by perezju@google.com, May 21 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 21 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=845124

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a7268f1a829b41ddc2a8875633c52f534ea4cf44f8de01b7ee1ec09c8c2a8b64


Bot(s) for this bug's original alert(s):

perf-go-phone-1024
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 23 2018

Cc: verwa...@chromium.org
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author verwaest@chromium.org ===

Hi verwaest@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Toon Verwaest
  Commit : 39496a95c53934ecb80d083003b4dd11056c9f20
  Date   : Thu May 03 12:34:17 2018
  Subject: Replace Context::closure with Context::scope_info, allowing closure to die.

Bisect Details
  Configuration: go-phone-1024-perf-bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_www_baidu_com_s_word_google
  Change       : 0.66% | 25243408.0 -> 25096317.7143

Revision                                                     Result                   N
android-chrome@fbe9ad968a                                    25243408 +- 107576       14      good
android-chrome@fbe9ad968a,chromium@555768                    25217515 +- 101148       14      good
android-chrome@fbe9ad968a,chromium@555769                    25211371 +- 99541.1      14      good
android-chrome@fbe9ad968a,chromium@555769,v8@c280e7d4f4      25367483 +- 177851       9       good
android-chrome@fbe9ad968a,chromium@555769,v8@ab814fb833      25203179 +- 93597.4      14      good
android-chrome@fbe9ad968a,chromium@555769,v8@7ed2e31bd9      25218978 +- 104995       14      good
android-chrome@fbe9ad968a,chromium@555769,v8@39496a95c5      25049132 +- 106975       9       bad       <--
android-chrome@fbe9ad968a,chromium@555770                    25081909 +- 158444       14      bad
android-chrome@fbe9ad968a,chromium@555771                    25077447 +- 159391       14      bad
android-chrome@fbe9ad968a,chromium@555774                    25086614 +- 173765       21      bad
android-chrome@fbe9ad968a,chromium@555779                    25049653 +- 115554       14      bad
android-chrome@9af30a5037                                    25096318 +- 112222       14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.www.baidu.com.s.word.google memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8945919017033009360


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
We just wanted to confirm the source of an improvement registered on the health plan for Android Go. Thanks for that work!

Sign in to add a comment