New issue
Advanced search Search tips

Issue 845123 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% improvement in memory.top_10_mobile at 1524784323:1524795391

Project Member Reported by perezju@google.com, May 21 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 21 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=845123

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1fbe58cc2c1fcdd516b86183d7a97692e04c36e2287ba5e7d30a5329af314111


Bot(s) for this bug's original alert(s):

perf-go-phone-1024
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 22 2018

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jgruber
  Commit : 3f99a376ddfc1a724f94d55b4a39986e56cd33b2
  Date   : Thu Apr 26 15:27:22 2018
  Subject: Reland "[builtins] Introduce further constant & external reference indirections"

Bisect Details
  Configuration: go-phone-1024-perf-bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_www_baidu_com_s_word_google
  Change       : 0.84% | 25606773.3333 -> 25391034.6667

Revision                                                     Result                   N
android-chrome@158b98e47f                                    25606773 +- 51773.0      6      good
android-chrome@d4ed8278b0                                    25721787 +- 197704       6      good
android-chrome@d4ed8278b0,chromium@554120                    25637819 +- 113839       6      good
android-chrome@d4ed8278b0,chromium@554127                    25672293 +- 128430       6      good
android-chrome@d4ed8278b0,chromium@554129                    25601296 +- 70915.2      9      good
android-chrome@d4ed8278b0,chromium@554129,v8@b8166b34fd      25655909 +- 126683       6      good
android-chrome@d4ed8278b0,chromium@554129,v8@c1e4885f7d      25656592 +- 140824       6      good
android-chrome@d4ed8278b0,chromium@554129,v8@3f99a376dd      25364297 +- 113399       9      bad       <--
android-chrome@d4ed8278b0,chromium@554129,v8@b66226828f      25378917 +- 100384       6      bad
android-chrome@d4ed8278b0,chromium@554130                    25389669 +- 93550.5      6      bad
android-chrome@d4ed8278b0,chromium@554131                    25426875 +- 114415       6      bad
android-chrome@d4ed8278b0,chromium@554135                    25403835 +- 108634       6      bad
android-chrome@069a782c20                                    25391035 +- 70887.6      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.www.baidu.com.s.word.google memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8945919083281758496


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
Assuming this can be closed since it bisects an improvement (which is expected with this CL).
Awesome, yes! We wanted to confirm the source for an improvement registered for Android Go. Thanks for this work!
I see, good to know, thanks :)

Sign in to add a comment