New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845105 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Add tracing for new audio service related code

Project Member Reported by maxmorin@chromium.org, May 21 2018

Issue description

This will help in investigating any new issues that come up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20

commit 8d4b3333029f6cb120cea2cf5da7d78fa6aedf20
Author: Max Morin <maxmorin@chromium.org>
Date: Wed May 23 10:06:09 2018

Add tracing for audio service streams.

Bug:  845105 
Change-Id: Id7dfb50a2e4b1539dfd92c62a127b29c31e65c16
Reviewed-on: https://chromium-review.googlesource.com/1065778
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561020}
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/media/audio_input_stream_broker.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/media/audio_input_stream_broker.h
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/media/audio_output_stream_broker.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/media/audio_output_stream_broker.h
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/media/forwarding_audio_stream_factory.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/renderer_host/media/audio_output_authorization_handler.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/renderer_host/media/audio_output_authorization_handler.h
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/content/renderer/media/audio_renderer_sink_cache_impl.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/services/audio/input_stream.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/services/audio/output_stream.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/services/audio/service.cc
[modify] https://crrev.com/8d4b3333029f6cb120cea2cf5da7d78fa6aedf20/services/audio/stream_factory.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22f3511384a00a07fba616ac0fc08b373d1c348

commit a22f3511384a00a07fba616ac0fc08b373d1c348
Author: Max Morin <maxmorin@chromium.org>
Date: Wed May 23 14:28:29 2018

Add some general audio service traces.

Drive-by fixed bug where DeviceNotifier calls AddDevicesChangedObserver
too often.

Bug:  845105 
Change-Id: Ia77bee1e40c485b8e97571867a01a6408d9014eb
Reviewed-on: https://chromium-review.googlesource.com/1065998
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561073}
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/BUILD.gn
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/debug_recording.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/debug_recording.h
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/debug_recording_unittest.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/device_notifier.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/device_notifier.h
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/device_notifier_unittest.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/owning_audio_manager_accessor.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/service.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/service_metrics.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/stream_factory.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/stream_factory.h
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/stream_factory_unittest.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/sync_reader.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/system_info.cc
[modify] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/system_info.h
[add] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/traced_service_ref.cc
[add] https://crrev.com/a22f3511384a00a07fba616ac0fc08b373d1c348/services/audio/traced_service_ref.h

Olga: are we done with this?
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/437548a2cf4a69da1480e376257ff51127b70804

commit 437548a2cf4a69da1480e376257ff51127b70804
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Tue May 29 12:44:21 2018

Add initially_muted to input stream creation trace event.

Bug:  845105 
Change-Id: I190ca21069e82322e8d1f6ddd189c15371395973
Reviewed-on: https://chromium-review.googlesource.com/1076207
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562394}
[modify] https://crrev.com/437548a2cf4a69da1480e376257ff51127b70804/services/audio/input_stream.cc

Status: Fixed (was: Started)
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment