New issue
Advanced search Search tips

Issue 845104 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::HTMLDocumentParser::DidReceiveEncodingDataFromBackgroundParser

Project Member Reported by ClusterFuzz, May 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5339414361014272

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::HTMLDocumentParser::DidReceiveEncodingDataFromBackgroundParser
  blink::BackgroundHTMLParser::UpdateDocument
  base::debug::TaskAnnotator::RunTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=560214:560216

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5339414361014272

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 21 2018

Labels: OS-Chrome
Project Member

Comment 2 by ClusterFuzz, May 21 2018

Components: Blink>HTML>Parser Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, May 21 2018

Labels: Test-Predator-Auto-Owner
Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/05b51a1e81c411a96c2f709bc23a4d1d24ab6cdc (Remove some unused thread-safe html/parser code).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, May 21 2018

Labels: OS-Windows OS-Linux
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c4105805fba22105c19a1d67650e1380e0d1406

commit 4c4105805fba22105c19a1d67650e1380e0d1406
Author: csharrison <csharrison@chromium.org>
Date: Wed May 23 03:31:23 2018

Check the weakptr parser before calling into it

This code used to bind a callback which did this implicity.

Bug:  845104 
Change-Id: I75db3232daaf6d20b5caa01361913663bf582d56
Reviewed-on: https://chromium-review.googlesource.com/1067358
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560922}
[modify] https://crrev.com/4c4105805fba22105c19a1d67650e1380e0d1406/third_party/blink/renderer/core/html/parser/background_html_parser.cc

Project Member

Comment 7 by ClusterFuzz, May 23 2018

ClusterFuzz has detected this issue as fixed in range 560913:560941.

Detailed report: https://clusterfuzz.com/testcase?key=5339414361014272

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::HTMLDocumentParser::DidReceiveEncodingDataFromBackgroundParser
  blink::BackgroundHTMLParser::UpdateDocument
  base::debug::TaskAnnotator::RunTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=560214:560216
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=560913:560941

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5339414361014272

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, May 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5339414361014272 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Issue 845788 has been merged into this issue.
Cc: csharrison@chromium.org
 Issue 845749  has been merged into this issue.

Sign in to add a comment