Issue metadata
Sign in to add a comment
|
Allow DPR, Device-Memory and viewport-width client hints for third party origins |
||||||||||||||||||||||
Issue descriptionThird party origins were eligible to receive these client hints until M-66, but that feature was deprecated as Accept-CH-Lifetime header was rolled out. We need to rollback that deprecation to avoid web compatibility issues with origins that heavily depend on these client hints. blink-dev thread has some more details: https://groups.google.com/a/chromium.org/d/msg/blink-dev/8RBFue7RMXQ/7TF4VPVzBAAJ The change would need to be merged back to M-67. To ensure a safe merge, the code changes should be guarded behind a finch trial.
,
May 21 2018
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d commit ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d Author: Tarun Bansal <tbansal@chromium.org> Date: Mon May 21 16:11:50 2018 Allow three client hints for third-party origins This change is guarded behind a finch trial. This CL would need to be merged back to M-67, and makes it possible for third-party origins to receive the DPR, Device-Memory and viewport-width client hints. The plan is to enable the finch trial only on Android. Change-Id: I67596e3f210e623464721210dec85d3e22497bd0 Bug: 845074 Reviewed-on: https://chromium-review.googlesource.com/1066776 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#560280} [modify] https://crrev.com/ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d/chrome/browser/client_hints/client_hints_browsertest.cc [modify] https://crrev.com/ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d/third_party/blink/renderer/core/loader/frame_fetch_context.cc
,
May 21 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8319636bc38843a1fcce67b231340ed571a70dea commit 8319636bc38843a1fcce67b231340ed571a70dea Author: Tarun Bansal <tbansal@chromium.org> Date: Tue May 22 16:25:51 2018 Add AllowClientHintsToThirdParty experiment to fieldtrial_testing_config.json. This experiment would be enabled only for Android Bug: 845074 Change-Id: Idbadb5e97082ff00d32c414d1c11eb47258813fd Reviewed-on: https://chromium-review.googlesource.com/1067855 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#560636} [modify] https://crrev.com/8319636bc38843a1fcce67b231340ed571a70dea/testing/variations/fieldtrial_testing_config.json
,
May 23 2018
,
May 23 2018
The CL in #5 went out on today's Android canary release (68.0.3437.3). I am going to request a merge to M-67 tomorrow.
,
May 23 2018
Requesting merge for CL in #5. The CL is pretty safe to merge: The code changes in the CL are guarded behind a finch trial, so we can revert it remotely if something bad happens. The CL undeprecates one of the Web APIs that Chrome provides to Web developers. We deprecated it earlier, but it turns out that some of the developers rely very heavily on it. Reverting it is critical to avoid breaking these webpages.
,
May 23 2018
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 24 2018
The NextAction date has arrived: 2018-05-24
,
May 24 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e731bcaf107a28bad5751f7cd0cf7557dacca0 commit 93e731bcaf107a28bad5751f7cd0cf7557dacca0 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu May 24 20:15:35 2018 Allow three client hints for third-party origins This change is guarded behind a finch trial. This CL would need to be merged back to M-67, and makes it possible for third-party origins to receive the DPR, Device-Memory and viewport-width client hints. The plan is to enable the finch trial only on Android. (cherry picked from commit ea0d8268f5b4d59fb18ba1d84cc33311cb51b59d) Change-Id: I67596e3f210e623464721210dec85d3e22497bd0 Bug: 845074 Reviewed-on: https://chromium-review.googlesource.com/1066776 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#560280} Reviewed-on: https://chromium-review.googlesource.com/1072492 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#695} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/93e731bcaf107a28bad5751f7cd0cf7557dacca0/chrome/browser/client_hints/client_hints_browsertest.cc [modify] https://crrev.com/93e731bcaf107a28bad5751f7cd0cf7557dacca0/third_party/blink/renderer/core/loader/frame_fetch_context.cc
,
May 25 2018
I still need to enable the field trial by default on Android ToT.
,
May 29 2018
Update on #13?
,
May 29 2018
I still need to do #13, but that's not urgent. I am going to remove the RBS label.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a738150eb7792e480c1169340dbdb593e2cb803e commit a738150eb7792e480c1169340dbdb593e2cb803e Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Jun 01 20:25:40 2018 Enable the experiment to send 3 client hints on Android platform. The experiment is currently enabled for 100% of Android population on M-67 and higher versions. Enabling the experiment in code makes it possible for us to remove the field trial experiment config from the server. Change-Id: Ib2d675d2f0eee840067d73e7356850049924bb98 Bug: 845074 Reviewed-on: https://chromium-review.googlesource.com/1075865 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#563775} [modify] https://crrev.com/a738150eb7792e480c1169340dbdb593e2cb803e/third_party/blink/renderer/core/loader/frame_fetch_context.cc [modify] https://crrev.com/a738150eb7792e480c1169340dbdb593e2cb803e/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
,
Jun 4 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tbansal@chromium.org
, May 21 2018