New issue
Advanced search Search tips

Issue 845073 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Toast message overlaps vertical scroll-bar on chrome://extensions page.

Reported by aiman.an...@etouch.net, May 21 2018

Issue description

Chrome Version: 68.0.3436.0 (Official Build) Revision e0f81fe637f233bf12e821915b72bc8d2194c3f2-refs/branch-heads/3436@{#1} (32/64 Bit).
 	
OS: Win(7,8,8.1,10).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://extensions and resize the window to extreme LHS.
2. Click on Developer Mode toggle button and click on Update button.
3. Observe toast message.

Actual Result: Toast message overlaps vertical scroll-bar.

Expected Result: Toast message should not overlap vertical scroll-bar.

This is a regression issue, broken in M-68  series, and below is the manually provided bisect info:
(Unable to provide bisect using new bisect script as it is giving trace-back error and unable to provide bisect using chromium builds as all chromium builds are giving good results)

Manual Bisect
Good Build: 68.0.3426.0 (Revision:557429)
Bad Build: 68.0.3427.0 (Revision:557758)

Change-Log:
https://chromium.googlesource.com/chromium/src/+log/68.0.3426.0..68.0.3427.0?pretty=fuller&n=10000

Suspecting: https://chromium.googlesource.com/chromium/src/+/0884a2c6a68829fdb63261916c9239c3ff3cab87

aee@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS).
   
Thank You!

 
Actual Result.mp4
1.0 MB View Download
Expected Result.mp4
875 KB View Download
Actual Result.png
13.9 KB View Download
Expected Result.png
13.7 KB View Download

Comment 1 by aee@chromium.org, May 21 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ecd29eda7510f260839c35d325785a0ecf63e1

commit 03ecd29eda7510f260839c35d325785a0ecf63e1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue May 22 21:32:58 2018

MD Extensions: move cr-toast up the DOM heirarchy so it is not altered by the styling of other elements

Bug:  845073 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I95b69e097480c38822587cf25430916d3bf81f4d
Reviewed-on: https://chromium-review.googlesource.com/1067483
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560785}
[modify] https://crrev.com/03ecd29eda7510f260839c35d325785a0ecf63e1/chrome/browser/resources/md_extensions/toolbar.html

Comment 3 by aee@chromium.org, May 22 2018

Status: Fixed (was: Started)
Labels: TE-Verified-68.0.3438.0 TE-Verified-M68
Update : 
Retested above issue in latest Beta build # 67.0.3396.56 on Windows(7,8,8.1,10) and the issue is fixed. Now, Toast message does not overlap vertical scroll-bar. Kindly review an attached screen-cast.

Thank you..!
Current Behaviour.mp4
671 KB View Download
Update: 
Please ignore previous comment

Correction:
Retested above issue in latest Canary build # 68.0.3438.0 on Windows(7,8,8.1,10) and the issue is fixed. Now, Toast message does not overlap vertical scroll-bar. Kindly review an attached screen-cast.

Thank you..!
Current Behaviour.mp4
671 KB View Download

Sign in to add a comment