New issue
Advanced search Search tips

Issue 845065 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 847101
issue 847105



Sign in to add a comment

Clean up OWNERS for file_manager

Project Member Reported by sashab@chromium.org, May 21 2018

Issue description

Go through the OWNERS files for file_manager, and add/remove people where necessary. Contact old owners to see if they are still currently reviewing patches, otherwise remove them.

Also make OWNERS files reference file://ui/file_manager/OWNERS as the source of truth where necessary to avoid duplication.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c80c3e332e1f742e503a1d3c6cd7aec1dd5387c

commit 9c80c3e332e1f742e503a1d3c6cd7aec1dd5387c
Author: Sasha Morrissey <sashab@chromium.org>
Date: Tue May 22 03:10:20 2018

Add file_manager_private.js externs OWNERS

Add file://ui/file_manager OWNERS as OWNERS of file_manager_private.js
in third_party/closure_compiler/externs/.

Bug:  845065 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I361745a9e3af786b9f2398d28073e3a01434b3ac
Reviewed-on: https://chromium-review.googlesource.com/1065836
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560471}
[modify] https://crrev.com/9c80c3e332e1f742e503a1d3c6cd7aec1dd5387c/third_party/closure_compiler/externs/OWNERS

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e39e18d6d4a9a381b20d07356c6685ddc6338da

commit 1e39e18d6d4a9a381b20d07356c6685ddc6338da
Author: Sasha Morrissey <sashab@chromium.org>
Date: Tue May 22 03:26:51 2018

Cross-reference ui/file_manager/OWNERS in c/b/chromeos/extensions

Cross-reference ui/file_manager/OWNERS in
chrome/browser/chromeos/extensions/file_manager/OWNERS
(fileManagerPrivate API) and chrome/browser/chromeos/file_manager/OWNERS
(other File Manager internals).

Bug:  845065 
Change-Id: I96c658bb5881e038c91f733d2c8a2664f26d75f7
Reviewed-on: https://chromium-review.googlesource.com/1065728
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560473}
[modify] https://crrev.com/1e39e18d6d4a9a381b20d07356c6685ddc6338da/chrome/browser/chromeos/extensions/file_manager/OWNERS
[modify] https://crrev.com/1e39e18d6d4a9a381b20d07356c6685ddc6338da/chrome/browser/chromeos/file_manager/OWNERS

Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9567f06c9cca7815789476d4280b85c84b0d8408

commit 9567f06c9cca7815789476d4280b85c84b0d8408
Author: Sasha Morrissey <sashab@chromium.org>
Date: Wed May 23 04:42:30 2018

Remove OWNERS from ui/file_manager

Remove OWNERS from ui/file_manager who are no longer experts in the code
or actively doing code reviews.
-hirono,-oka,-yawano,-yoshiki

Bug:  845065 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I492a7c6fad5a916df8de4d662209036424b20652
Reviewed-on: https://chromium-review.googlesource.com/1068550
Reviewed-by: Daichi Hirono <hirono@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560944}
[modify] https://crrev.com/9567f06c9cca7815789476d4280b85c84b0d8408/ui/file_manager/OWNERS

Comment 4 by sashab@chromium.org, May 28 2018

Blockedon: 847101

Comment 5 by noel@chromium.org, May 28 2018

Blockedon: 847105
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/704fde981a14d410157232a7a8dbca8bab7f8e0b

commit 704fde981a14d410157232a7a8dbca8bab7f8e0b
Author: Sam McNally <sammc@chromium.org>
Date: Fri Jun 01 06:25:10 2018

Update file_manager_private*.idl OWNERS to match the implementation.

Change per-file OWNERS for file_manager_private*.idl to match
chrome/browser/chromeos/extensions/file_manager/OWNERS.

Bug:  845065 
Change-Id: I04d07a5cad4abc42eb61f21aea1ff7528a34745f
Reviewed-on: https://chromium-review.googlesource.com/1082063
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563549}
[modify] https://crrev.com/704fde981a14d410157232a7a8dbca8bab7f8e0b/chrome/common/extensions/api/OWNERS

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d408a476237e357f79caa1077762961cb93d526

commit 5d408a476237e357f79caa1077762961cb93d526
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri Jun 08 06:08:39 2018

Add file_manager OWNERS to drive_internals page

Add OWNERS in file://ui/file_manager/OWNERS to drive_internals page,
since this is mainly used for debugging issues with the Drive Sync
engine which is primarly used by the file manager.

Bug:  845065 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iff904ccc44c163621f620fa930e838697f4f8f1e
Reviewed-on: https://chromium-review.googlesource.com/1075837
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565568}
[modify] https://crrev.com/5d408a476237e357f79caa1077762961cb93d526/chrome/browser/resources/chromeos/OWNERS
[modify] https://crrev.com/5d408a476237e357f79caa1077762961cb93d526/chrome/browser/ui/webui/chromeos/OWNERS

Owner: slangley@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment