New issue
Advanced search Search tips

Issue 845058 link

Starred by 2 users
Status: Fixed
Owner:
slangley@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Team Drives don't appear on first login

Project Member Reported by sashab@chromium.org, May 21 2018 
Chrome Version: ToT (
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Clear user-data-dir.
(2) Re-open chromeos with --team-drives.

What is the expected result?

Team drives root does not appear.

What happens instead?

Team drives do not appear on first login, they only appear on subsequent logins.

Also, after a while, chrome crashes with error:

[241950:241975:0521/135234.995287:FATAL:change_list_processor.cc(140)] Check failed: !new_start_page_token.empty(). 
#0 0x7fe20313856c base::debug::StackTrace::StackTrace()
#1 0x7fe20307faeb logging::LogMessage::~LogMessage()
#2 0x563650be3165 drive::internal::ChangeListProcessor::ApplyUserChangeList()


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279da6b0d92b52eca17e188c8b577e43c4f25eaf

commit 279da6b0d92b52eca17e188c8b577e43c4f25eaf
Author: Stuart Langley <slangley@chromium.org>
Date: Fri May 25 11:22:05 2018

Use TeamDriveListLoader to obtain the users team drive list on startup.

Currently the lists of users team drives is loaded on each update using
ChangeListLoader. We remove the logic from ChangeListLoader and use
TeamDriveListLoader instead. The full list is loaded only on startup, after
that team drive changes (new/removed/changed) will arrive via default change
list processing.

Bug:  845058 ,  829154 , 723955
Change-Id: I06c8d6d8e26ca1f02003768b879af8aa96a78b5b
Reviewed-on: https://chromium-review.googlesource.com/1073036
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561828}
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/change_list_loader.h
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/default_corpus_change_list_loader.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/default_corpus_change_list_loader.h

Comment 2 by slangley@chromium.org, May 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment