simplechrome: cros chrome-sdk fails at python2 goma_ctl.py update |
||||||
Issue description
It's a recent chromium checkout and my depot_tools are up to date.
semenzato@luigi:~/chromium/src$ cros chrome-sdk --board cyan --log-level=info
15:30:09: INFO: Installing Goma.
15:30:10: ERROR: cros chrome-sdk failed before completing.
15:30:10: ERROR: return code: 1; command: python2 goma_ctl.py update
Traceback (most recent call last):
File "goma_ctl.py", line 2518, in <module>
sys.exit(main())
File "goma_ctl.py", line 2513, in main
goma.Dispatch(sys.argv[1:])
File "goma_ctl.py", line 1149, in Dispatch
self._CreateGomaTmpDirectory()
File "goma_ctl.py", line 1111, in _CreateGomaTmpDirectory
tmp_dir = self._env.GetGomaTmpDir()
File "goma_ctl.py", line 1469, in GetGomaTmpDir
env=env).strip()
File "/usr/lib/python2.7/subprocess.py", line 212, in check_output
process = Popen(stdout=PIPE, *popenargs, **kwargs)
File "/usr/lib/python2.7/subprocess.py", line 390, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1024, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
cmd=['python2', 'goma_ctl.py', 'update'], cwd=/tmp/tmp1s535E/goma
,
May 21 2018
Goma is installed and running.
,
May 21 2018
I don't understand where the problem is. semenzato@luigi:~/chromium/src$ env | grep GOMA GOMA_DIR=/usr/local/google/home/semenzato/goma semenzato@luigi:~/chromium/src$ /usr/local/google/home/semenzato/goma/gomacc tmp_dir /run/user/98386/goma_semenzato semenzato@luigi:~/chromium/src$ ls -l /run/user/98386/goma_semenzato total 4 drwx------ 2 semenzato primarygroup 80 May 20 15:52 goma_cache -r-------- 1 semenzato primarygroup 0 May 20 17:19 goma_compiler_proxy.lock.8088 -rw-rw---- 1 semenzato primarygroup 219 May 20 17:19 goma_compiler_proxy.stderr drwx------ 2 semenzato primarygroup 40 May 20 15:52 goma_crash srw------- 1 semenzato primarygroup 0 May 20 17:19 goma.ipc semenzato@luigi:~/chromium/src$ But from the stack, it's more likely that the "No such file" is gomacc, so why is it not finding it? Mmm... am I looking at the wrong goma_ctl.py? I.e. the one in /usr/local/google/home/semenzato/goma. I just renamed it to something else, and I am getting the same error. Where's the other copy?
,
May 21 2018
,
May 21 2018
I was looking in the wrong place---the script used is in ~/chromium/src/third_party/chromite. Apparently there is a bug in the goma tools (b/79714929). Our script downloads the goma directory before running goma_ctl.py, so I cannot use the workaround in comment #7 of that bug.
,
May 21 2018
workaround I come up with is setting --gomadir.
,
May 21 2018
,
May 21 2018
#7 thank you! More precisely: 1. first get the older goma_ctl.py as per b/79714929#comment7 and replace the one in your goma directory (for me, $HOME/goma). 2. then run this cros chrome-sdk --board $BOARD --gomadir=$HOME/goma (I am getting other errors now, but may be unrelated 09:06:35: WARNING: Running gn gen gn.py: Could not find gn executable at: /usr/local/google2/home/semenzato/chromium/src/buildtools/linux64/gn )
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0bdff2baa748c99e6306c707eb673fc292ec9833 commit 0bdff2baa748c99e6306c707eb673fc292ec9833 Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Date: Tue May 29 05:46:33 2018 chrome-sdk: update goma auto install to new procedure. Bug: 845045 Change-Id: I229f1677b865f3fd824710cfbce78d7d92928ee2 Reviewed-on: https://chromium-review.googlesource.com/1065557 Commit-Ready: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Tested-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0bdff2baa748c99e6306c707eb673fc292ec9833/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/0bdff2baa748c99e6306c707eb673fc292ec9833/cli/cros/cros_chrome_sdk_unittest.py
,
May 29 2018
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ecbeb34a503d9369a02539af31a47110918341 commit e1ecbeb34a503d9369a02539af31a47110918341 Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 29 06:59:30 2018 Roll src/third_party/chromite/ 626c28c23..0bdff2baa (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/626c28c2383c..0bdff2baa748 $ git log 626c28c23..0bdff2baa --date=short --no-merges --format='%ad %ae %s' 2018-05-25 yyanagisawa chrome-sdk: update goma auto install to new procedure. Created with: roll-dep src/third_party/chromite BUG= chromium:845045 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie2a4dad7e7587dd22bbcc2aa5e6b6819c7b547dd Reviewed-on: https://chromium-review.googlesource.com/1075855 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562354} [modify] https://crrev.com/e1ecbeb34a503d9369a02539af31a47110918341/DEPS
,
Jun 5 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by semenzato@chromium.org
, May 20 2018