New issue
Advanced search Search tips

Issue 845037 link

Starred by 4 users
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Jul 9
Cc:
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

login screen: arrow keys no longer work for selecting user

Project Member Reported by pawalls@google.com, May 20 2018 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10682.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3431.0 Safari/537.36
Platform: 10682.0.0 (Official Build) dev-channel eve

Steps to reproduce the problem:
1. Ensure there are at least two users on the machine
2. Go to login screen (reboot or logout)
3. Press left and right arrows

What is the expected behavior?
This should allow you to select the various users on the device.

What went wrong?
Nothing happens.

Did this work before? Yes stable channel

Chrome version: 68.0.3431.0  Channel: dev
OS Version: 10682.0.0
Flash Version:

Comment 1 by zalcorn@chromium.org, May 25 2018

Components: -UI UI>Shell>StartScreen
Owner: jdufault@chromium.org
+jdufault is keyboard nav working on views login?

Comment 2 by jdufault@chromium.org, May 25 2018

Labels: M-69
Status: Available (was: Unconfirmed)
webui login has special logic for arrow-keys that remap it to tab/shift-tab, likely this has not been ported yet.

Comment 3 by jdufault@chromium.org, May 25 2018

Labels: ReleaseBlock-Beta

Comment 4 by jdufault@chromium.org, May 31 2018

Cc: jdufault@chromium.org
Owner: qnnguyen@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a

commit 0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jul 03 23:14:54 2018

Use arrow keys to navigate through users on Views-based login screen.

Bug:  845037 
Change-Id: I60574af1513793a0872c4d02c20c829f0adda9df
Reviewed-on: https://chromium-review.googlesource.com/1117769
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572389}
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/BUILD.gn
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/lock_screen.h
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_keyboard_test_base.h
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_password_view.h
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/scrollable_users_list_view.cc
[rename] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/views_utils.cc
[rename] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/login/ui/views_utils.h
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/metrics/login_metrics_recorder_unittest.cc
[modify] https://crrev.com/0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a/ash/shelf/login_shelf_view_unittest.cc

Comment 6 by qnnguyen@chromium.org, Jul 9

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8df89ca5be5c019e100487a0a069c16ab81561c

commit c8df89ca5be5c019e100487a0a069c16ab81561c
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Tue Jul 10 01:04:40 2018

Revert "Use arrow keys to navigate through users on Views-based login screen."

This reverts commit 0f9ea81ef2856b27ae3fda79bc2440c5b3fb888a.

Reason for revert: this change has broken the Easy Unlock
feature. When Easy Unlock is enabled, its icon is intended
to appear in the password field of a user pod on the login
or lock screen. This change has prevented that icon from
displaying. More details at  crbug.com/861918 .

Original change's description:
> Use arrow keys to navigate through users on Views-based login screen.
>
> Bug:  845037 
> Change-Id: I60574af1513793a0872c4d02c20c829f0adda9df
> Reviewed-on: https://chromium-review.googlesource.com/1117769
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572389}

TBR=derat@chromium.org,msw@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org


Bug:  845037 
Change-Id: I9047f3b8d955bddc7f2d006e5da90dd30cfe98bc
Reviewed-on: https://chromium-review.googlesource.com/1130755
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573571}
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/BUILD.gn
[rename] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/layout_util.cc
[rename] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/layout_util.h
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/lock_screen.h
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_keyboard_test_base.h
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_password_view.h
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/login/ui/scrollable_users_list_view.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/metrics/login_metrics_recorder_unittest.cc
[modify] https://crrev.com/c8df89ca5be5c019e100487a0a069c16ab81561c/ash/shelf/login_shelf_view_unittest.cc
►

Sign in to add a comment