New issue
Advanced search Search tips

Issue 844989 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate rlz/lib/financial_ping.cc to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Blocking: 773295
Components: Internals>Core
Summary: Migrate rlz/lib/financial_ping.cc to network::SimpleURLLoader (was: Migrate rlz/lib/financial_ping.cc)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Owner: ----
Status: Available (was: Started)
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9ccc743cafb11e55bf55b44358b9509f510b7b7

commit a9ccc743cafb11e55bf55b44358b9509f510b7b7
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Jul 25 13:11:26 2018

Remove superfluous calls to rlz_lib::SetURLRequestContext

rlz_lib::SetURLRequestContext does not need to be called explicitly
since URLRequestRAII's ctor call it, and an instance of it is already
being constructed.

This is a driven-by preparation for  crbug.com/844989 .

TBR=rogerta@chromium.org

BUG= 844989 

Change-Id: Ib7e2e0809c4e1e65c386e02008fdce877b829b08
Reviewed-on: https://chromium-review.googlesource.com/1149620
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577853}
[modify] https://crrev.com/a9ccc743cafb11e55bf55b44358b9509f510b7b7/rlz/lib/rlz_lib_test.cc

Cc: rogerta@chromium.org
 Issue 827287  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a739bf463eeb57b9254d35b45c99fd66c49c4d17

commit a739bf463eeb57b9254d35b45c99fd66c49c4d17
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Aug 13 20:50:30 2018

Migrate FinancialPing to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates RLZTracker and FinancialPing away from URLFetcher.

Bug=773295, 844989 

Change-Id: I07fc8d09b359727ad8649e38355dd6af2bc60b02
Reviewed-on: https://chromium-review.googlesource.com/1142749
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582698}
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/chrome/browser/rlz/chrome_rlz_tracker_delegate.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/BUILD.gn
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/DEPS
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker_delegate.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker_unittest.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/BUILD.gn
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/DEPS
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/financial_ping.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/financial_ping.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib_test.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/test/rlz_unittest_main.cc

Status: Fixed (was: Started)

Sign in to add a comment