Issue 844980 has been merged into this issue.
Issue 840393 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c359e685c54a68b12029856226c667d84d130237 commit c359e685c54a68b12029856226c667d84d130237 Author: Chris Mumford <cmumford@chromium.org> Date: Mon Aug 20 16:38:21 2018 Added offset/length to SimpleURLLoader::AttachFileForUpload. Previously SimpleURLLoader would always upload the entire file. This allows the caller to specify a portion of the file to be uploaded. Bug: 844979 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8c2d6267fb65a5012f49c9f3ce943c44dc4837db Reviewed-on: https://chromium-review.googlesource.com/1180072 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584472} [modify] https://crrev.com/c359e685c54a68b12029856226c667d84d130237/services/network/public/cpp/simple_url_loader.cc [modify] https://crrev.com/c359e685c54a68b12029856226c667d84d130237/services/network/public/cpp/simple_url_loader.h [modify] https://crrev.com/c359e685c54a68b12029856226c667d84d130237/services/network/public/cpp/simple_url_loader_unittest.cc
Removing canary blocker since on Windows it's only used from the syncFileSystem chrome apps API, and that was only used by 25 users on canary in the last week: https://uma.googleplex.com/histograms?endDate=20180825&dayCount=7&histograms=Extensions.FunctionCalls&fixupData=true&uniqueUsers=true&showMax=true&filters=channel%2Ceq%2C1%2Cplatform%2Ceq%2CW%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d95d5c82388154218625765098d5fcb89c9e7323 commit d95d5c82388154218625765098d5fcb89c9e7323 Author: Chris Mumford <cmumford@google.com> Date: Tue Sep 11 18:22:12 2018 Switched the Google Drive API to use SimpleURLLoader. Prior implementation used net::URLRequestContext, but using SimpleURLLoader is compatible with the network service. Bug: 844979 Change-Id: I26bb07d1b440443ab320979b694eefe1f8e32cf6 Reviewed-on: https://chromium-review.googlesource.com/1176363 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#590409} [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/base/win/windows_types.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/chromeos/drive/drive_integration_service.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/sync_file_system/drive_backend/sync_engine.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/sync_file_system/drive_backend/sync_engine.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/components/drive/drive_api_util.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/components/drive/service/drive_api_service.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/components/drive/service/drive_api_service.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/components/drive/service/drive_api_service_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/BUILD.gn [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/DEPS [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/base_requests.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/base_requests.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/base_requests_server_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/base_requests_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/drive_api_requests.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/drive_api_requests.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/drive_api_requests_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/files_list_request_runner_unittest.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/request_sender.cc [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/request_sender.h [modify] https://crrev.com/d95d5c82388154218625765098d5fcb89c9e7323/google_apis/drive/request_sender_unittest.cc
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)