Issue 844977 has been merged into this issue.
I'm going to start working on this.
Issue 859015 has been merged into this issue.
The patch for this is out for review, after which the Geolocation API should work with the Network Service enabled. https://chromium-review.googlesource.com/c/chromium/src/+/1119398
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19aaccdb45521ef1ec19717a22fd4232f66499cd commit 19aaccdb45521ef1ec19717a22fd4232f66499cd Author: Reilly Grant <reillyg@chromium.org> Date: Mon Jul 16 22:06:37 2018 Port //services/device/geolocation to network::SimpleURLLoader This change migrates users of net::URLFetcher in //services/device/geolocation to network::SimpleURLLoader. The asynchronous plumbing for requesting a net::URLRequestContextGetter in the device service is replaced with simply passing in a network::SharedURLLoaderFactory. The tests are migrated from net::TestURLFetcherFactory to network::TestURLLoaderFactory. Bug: 844976 Change-Id: Icdc35cb973554a9ac2592ced9873bf15bf0bc82d Reviewed-on: https://chromium-review.googlesource.com/1119398 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575444} [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/chromecast/browser/cast_content_browser_client.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/content/public/browser/content_browser_client.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/content/public/browser/content_browser_client.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/BUILD.gn [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/DEPS [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/device_service.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/device_service.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/device_service_test_base.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/device_service_test_base.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/BUILD.gn [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/DEPS [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/geolocation_provider.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/geolocation_provider_impl.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/geolocation_provider_impl.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/geolocation_service_unittest.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/location_arbitrator.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/location_arbitrator.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/location_arbitrator_unittest.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/network_location_provider.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/network_location_provider.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/network_location_provider_unittest.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/network_location_request.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/network_location_request.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_geolocation_provider.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_geolocation_provider.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_geolocator_unittest.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_location_notifier.cc [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_location_notifier.h [modify] https://crrev.com/19aaccdb45521ef1ec19717a22fd4232f66499cd/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)