New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844974 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/variations/service/variations_service.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763

commit ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Fri Jun 15 13:56:26 2018

Migrate VariationsService to SimpleURLLoader

TBR=sdefresne@chromium.org

Bug:  844974 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie3e26e7fb7ce5e2624c45927f03f0ee8613f766a
Reviewed-on: https://chromium-review.googlesource.com/1097213
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567628}
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/android_webview/browser/aw_variations_service_client.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/android_webview/browser/aw_variations_service_client.h
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/chrome/browser/metrics/variations/chrome_variations_service_client.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/chrome/browser/metrics/variations/chrome_variations_service_client.h
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/BUILD.gn
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/DEPS
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/variations_field_trial_creator_unittest.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/variations_service.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/variations_service.h
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/variations_service_client.h
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/ios/chrome/browser/variations/ios_chrome_variations_service_client.cc
[modify] https://crrev.com/ecbf76e29fd1f8dc3c39b66f1a7eb97fdfeff763/ios/chrome/browser/variations/ios_chrome_variations_service_client.h

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment