Issue 853810 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4 commit cb02821074ba14de3d6a503ef204b694b25017a4 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jun 19 15:40:30 2018 Annotate many of the browser_tests disabled under the NetworkService. Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG= 844950 , 844951 , 844952 , 853251 , 844928 , BUG= 843205 , 844949 , 844925 , 844939 , 821021, BUG=853798, 844973 , 844927 , 844926 , 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464} [modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1097337
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5 commit ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Jun 28 13:10:43 2018 Migrate client_update::SendProtocolRequest to SimpleURLLoader URLFetcher et al will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. CL migrates SendProtocolRequest to the new API. Major remarks: * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs of the former is kept (are almost the same) in the later. This allows the extensive set of unit tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. This is needed because of the nature of the tests: some tests manipulate the TestConfigurator directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates using EmbeddedTestServer in order to intercept URL loads. Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. It will be done in a follow up CL. BUG=773295, 844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 Reviewed-on: https://chromium-review.googlesource.com/1097337 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571097} [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/chrome_update_client_config.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/chrome_update_client_config.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/component_updater/BUILD.gn [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/BUILD.gn [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/DEPS [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/configurator.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/ping_manager_unittest.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/test_configurator.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/test_configurator.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/update_checker_unittest.cc [add] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/url_loader_post_interceptor.cc [add] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/url_loader_post_interceptor.h [delete] https://crrev.com/d7b3885050f559a684c25acd04875a14c97cbcda/components/update_client/url_request_post_interceptor.cc [delete] https://crrev.com/d7b3885050f559a684c25acd04875a14c97cbcda/components/update_client/url_request_post_interceptor.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/utils.cc [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/utils.h [modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771fdba11217a8b117540b50fe4c2d1eac419332 commit 771fdba11217a8b117540b50fe4c2d1eac419332 Author: Olga Sharonova <olka@chromium.org> Date: Thu Jun 28 15:01:35 2018 Revert "Migrate client_update::SendProtocolRequest to SimpleURLLoader" This reverts commit ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5. Reason for revert: multiple tests failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/50984 UpdateServiceTest.UninstallExtensionWhileUpdating PolicyUpdateServiceTest.PolicyCorruptedOnStartup PolicyUpdateServiceTest.FailedUpdateRetries UpdateServiceTest.TwoUpdateCheckErrors UpdateServiceTest.UpdateCheckError UpdateServiceTest.SuccessfulUpdate ComponentUpdaterPolicyTest.EnabledComponentUpdates PolicyUpdateServiceTest.Backoff UpdateServiceTest.PolicyCorrupted UpdateServiceTest.NoUpdate [5637:5892:0628/072239.370548:FATAL:http_request_headers.cc(129)] "POST /pinghost/service/ping HTTP/1.1" is missing colon delimiter. Original change's description: > Migrate client_update::SendProtocolRequest to SimpleURLLoader > > URLFetcher et al will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. CL migrates SendProtocolRequest to the new API. > > Major remarks: > > * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs > of the former is kept (are almost the same) in the later. This allows the extensive set of unit > tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used > to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. > > * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory > and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. > This is needed because of the nature of the tests: some tests manipulate the TestConfigurator > directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, > eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. > Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then > have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates > using EmbeddedTestServer in order to intercept URL loads. > > Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there > some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), > so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. > It will be done in a follow up CL. > > BUG=773295, 844973 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 > Reviewed-on: https://chromium-review.googlesource.com/1097337 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571097} TBR=droger@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,sorin@chromium.org,emaxx@chromium.org,tonikitoo@igalia.com,mxnguyen@chromium.org Change-Id: I0974aeef814ac153bf7da86ebf3e2f09b410bdd6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118585 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#571125} [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/chrome_update_client_config.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/chrome_update_client_config.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/component_updater/BUILD.gn [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/BUILD.gn [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/DEPS [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/configurator.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/ping_manager_unittest.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/test_configurator.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/test_configurator.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/update_checker_unittest.cc [delete] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/components/update_client/url_loader_post_interceptor.cc [delete] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/components/update_client/url_loader_post_interceptor.h [add] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/url_request_post_interceptor.cc [add] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/url_request_post_interceptor.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/utils.cc [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/utils.h [modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
Reopening to track the re-landing (https://chromium-review.googlesource.com/c/chromium/src/+/1118646).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b616250114f1f5b45878afa71a41d7f2e3eddad3 commit b616250114f1f5b45878afa71a41d7f2e3eddad3 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Jun 28 20:21:55 2018 Reland "Migrate client_update::SendProtocolRequest to SimpleURLLoader" This is a reland of ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5 Difference from the original CL is minor, but indeed the cause of failures on debug bots: - headers.AddHeadersFromString(request.all_headers); + for (auto it : request.headers) + headers.SetHeader(it.first, it.second); Basically, network::ResourceRequest::all_headers can contain lines that do not match the "key: value" syntax expected by net::HttpRequestHeaders. Hence, we iterate over network::ResourceRequest::headers instead. TBR=emaxx@chromium.org,sorin@chromium.org,rdevlin.cronin@chromium.org,droger@chromium.org,mmenke@chromium.org Original change's description: > Migrate client_update::SendProtocolRequest to SimpleURLLoader > > URLFetcher et al will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. CL migrates SendProtocolRequest to the new API. > > Major remarks: > > * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs > of the former is kept (are almost the same) in the later. This allows the extensive set of unit > tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used > to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. > > * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory > and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. > This is needed because of the nature of the tests: some tests manipulate the TestConfigurator > directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, > eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. > Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then > have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates > using EmbeddedTestServer in order to intercept URL loads. > > Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there > some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), > so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. > It will be done in a follow up CL. > > BUG=773295, 844973 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 > Reviewed-on: https://chromium-review.googlesource.com/1097337 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571097} Bug: 773295, 844973 Change-Id: I3a8252aecf687d08e41c0d09cb9bd245fe3f712b Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118646 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#571242} [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/chrome_update_client_config.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/chrome_update_client_config.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/component_updater/BUILD.gn [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/BUILD.gn [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/DEPS [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/configurator.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/ping_manager_unittest.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/test_configurator.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/test_configurator.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/update_checker_unittest.cc [add] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/url_loader_post_interceptor.cc [add] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/url_loader_post_interceptor.h [delete] https://crrev.com/7d24b26391b9f7e35a24213db8092e7304204be7/components/update_client/url_request_post_interceptor.cc [delete] https://crrev.com/7d24b26391b9f7e35a24213db8092e7304204be7/components/update_client/url_request_post_interceptor.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/utils.cc [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/utils.h [modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38dd68057ead0c3798819dcfe583621e672a09e3 commit 38dd68057ead0c3798819dcfe583621e672a09e3 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Jul 13 14:07:56 2018 Use network::GetUploadData in URLLoaderPostInterceptor ... instead of our own copy. Post-mortem clean up. BUG= 844973 Change-Id: I0e4a69b94c0fd4d3a4fd55ecf43b80435a2e0dc5 Reviewed-on: https://chromium-review.googlesource.com/1136511 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#574904} [modify] https://crrev.com/38dd68057ead0c3798819dcfe583621e672a09e3/components/update_client/url_loader_post_interceptor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed7e4d279e9f46131c2be56a528fff72166f5efa commit ed7e4d279e9f46131c2be56a528fff72166f5efa Author: Doug Turner <dougt@chromium.org> Date: Fri Jul 13 18:48:00 2018 UpdateServiceTest pass now that 844973 is fixed TBR=jam@chromium.org Bug: 844973 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2fa684a39ddb01c582173d6955fa264792c779ea Reviewed-on: https://chromium-review.googlesource.com/1136718 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#574996} [modify] https://crrev.com/ed7e4d279e9f46131c2be56a528fff72166f5efa/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecc52c96b42244d60f03f369bb82628d27dc1f01 commit ecc52c96b42244d60f03f369bb82628d27dc1f01 Author: Matt Menke <mmenke@chromium.org> Date: Tue Aug 14 15:59:10 2018 Remove update_client::Configurator::RequestContext() It's no longer used, and URLRequestContextGetters will no longer be created in the browser process, at some point. TBR=noyau@chromium.org Bug: 844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0c3ea06e0a99795a1f09c78c005ec16f4207ef77 Reviewed-on: https://chromium-review.googlesource.com/1171105 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582928} [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/chrome/browser/extensions/updater/chrome_update_client_config.cc [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/chrome/browser/extensions/updater/chrome_update_client_config.h [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/components/update_client/configurator.h [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/components/update_client/test_configurator.cc [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/components/update_client/test_configurator.h [modify] https://crrev.com/ecc52c96b42244d60f03f369bb82628d27dc1f01/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c802c606c3e057c63599da61140481c26ec0cbda commit c802c606c3e057c63599da61140481c26ec0cbda Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Aug 17 16:32:22 2018 Remove leftover references to URLFetcher et al in components/update_client/ Now that components/update_client/* have moved away from URLFetcher and friends (see [1] and [2]), we can remove these helper classes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1118646 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1160725 BUG= 844973 Change-Id: I362f135a913aba9bdddaa47a6c51a282c261a900 Reviewed-on: https://chromium-review.googlesource.com/1179941 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#584096} [modify] https://crrev.com/c802c606c3e057c63599da61140481c26ec0cbda/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/c802c606c3e057c63599da61140481c26ec0cbda/components/update_client/utils.cc [modify] https://crrev.com/c802c606c3e057c63599da61140481c26ec0cbda/components/update_client/utils.h
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)