The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43bebb1ddc7a74e863f935f4bc66dde4ee69c424 commit 43bebb1ddc7a74e863f935f4bc66dde4ee69c424 Author: Mark Pilgrim <pilgrim@chromium.org> Date: Thu Jun 07 17:28:21 2018 Migate SyncStoppedReporter to SimpleURLLoader Bug: 844966 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3c198d95735770668eed4a1342a3979224239529 Reviewed-on: https://chromium-review.googlesource.com/1089132 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#565321} [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/chrome/browser/sync/profile_sync_test_util.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/BUILD.gn [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/DEPS [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/browser_sync/profile_sync_test_util.h [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/sync/BUILD.gn [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/sync/driver/DEPS [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/sync/driver/sync_stopped_reporter.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/sync/driver/sync_stopped_reporter.h [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/components/sync/driver/sync_stopped_reporter_unittest.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc [modify] https://crrev.com/43bebb1ddc7a74e863f935f4bc66dde4ee69c424/ios/chrome/browser/sync/profile_sync_service_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90c431a8cffd86fc4a2d9883a4af25909c8df063 commit 90c431a8cffd86fc4a2d9883a4af25909c8df063 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Jun 07 18:54:59 2018 Revert "Migate SyncStoppedReporter to SimpleURLLoader" This reverts commit 43bebb1ddc7a74e863f935f4bc66dde4ee69c424. Reason for revert: suspected to have broken analyze on android CQ bot https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/6471 ERROR at //components/browser_sync/profile_sync_test_util.cc:27:11: Include not allowed. #include "services/network/test/test_url_loader_factory.h" Original change's description: > Migate SyncStoppedReporter to SimpleURLLoader > > Bug: 844966 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3c198d95735770668eed4a1342a3979224239529 > Reviewed-on: https://chromium-review.googlesource.com/1089132 > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565321} TBR=sky@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,mastiz@chromium.org Change-Id: Iaf73cd80c169fc9451d82c42f807685258d3b09f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844966 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091306 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565362} [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/chrome/browser/sync/profile_sync_test_util.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/BUILD.gn [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/DEPS [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/browser_sync/profile_sync_test_util.h [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/sync/BUILD.gn [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/sync/driver/DEPS [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/sync/driver/sync_stopped_reporter.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/sync/driver/sync_stopped_reporter.h [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/components/sync/driver/sync_stopped_reporter_unittest.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc [modify] https://crrev.com/90c431a8cffd86fc4a2d9883a4af25909c8df063/ios/chrome/browser/sync/profile_sync_service_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/215ccf9c94a15d2ceaf82871a256c7dba535a301 commit 215ccf9c94a15d2ceaf82871a256c7dba535a301 Author: Mark Pilgrim <pilgrim@chromium.org> Date: Mon Jun 11 22:32:19 2018 Reland Migrate SyncStoppedReporter to SimpleURLLoader Original CL <https://chromium-review.googlesource.com/c/chromium/src/+/1089132> was speculatively reverted after an unrelated CL was reverted which caused the original CL to fail due to BUILD.gn changes. This reland CL is identical to the original CL + BUILD.gn changes (and 1 include). Patchset 1 is the original CL. Patchset 3 is the reland. Bug: 844966 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I20b832f3ba86278b2df423295ef2d62b6f7b65d6 TBR: mastiz@chromium.org, sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1095325 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#566176} [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/chrome/browser/sync/profile_sync_test_util.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/BUILD.gn [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/DEPS [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/browser_sync/profile_sync_test_util.h [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/sync/BUILD.gn [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/sync/driver/DEPS [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/sync/driver/sync_stopped_reporter.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/sync/driver/sync_stopped_reporter.h [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/components/sync/driver/sync_stopped_reporter_unittest.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc [modify] https://crrev.com/215ccf9c94a15d2ceaf82871a256c7dba535a301/ios/chrome/browser/sync/profile_sync_service_factory.cc
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)