Migrate components/suggestions/suggestions_service_impl.cc to network::SimpleURLLoader |
|||||||||
Issue description
,
May 30 2018
,
Jun 11 2018
,
Jun 25 2018
,
Jun 26 2018
,
Jun 26 2018
This component is for most likely suggestions, right? Justin, will you please take a look at this migration request?
,
Jul 16
,
Jul 16
Taking a first look now.
,
Jul 19
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212 commit 05e02f2c0db74dd5d08f9331033c9f4b7c0e7212 Author: Justin DeWitt <dewittj@chromium.org> Date: Thu Jul 26 21:26:21 2018 [Suggestions] Port to using SimpleURLLoader instead of URLFetcher. Required for network servicification. BUG= 844965 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If09ae972d4e4c0d0015f862774410d99bbe9b876 Reviewed-on: https://chromium-review.googlesource.com/1143709 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#578443} [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/DEPS [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl.cc [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl.h [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl_unittest.cc [modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/ios/chrome/browser/suggestions/suggestions_service_factory.mm
,
Aug 3
is this migrated? can we close?
,
Aug 3
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)