New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844965 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: Task

Blocking:
issue 773295



Sign in to add a comment

Migrate components/suggestions/suggestions_service_impl.cc to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Owner: ----
Status: Available (was: Started)
Blocking: 773295
Components: UI>Browser>NewTabPage
Summary: Migrate components/suggestions/suggestions_service_impl.cc to network::SimpleURLLoader (was: Migrate components/suggestions/suggestions_service_impl.cc)
Labels: Type-Task
Labels: zine-triaged
Owner: dewittj@chromium.org
Status: Assigned (was: Available)
This component is for most likely suggestions, right? Justin, will you please take a look at this migration request?
Cc: morlovich@chromium.org
Taking a first look now.
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212

commit 05e02f2c0db74dd5d08f9331033c9f4b7c0e7212
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Jul 26 21:26:21 2018

[Suggestions] Port to using SimpleURLLoader instead of URLFetcher.

Required for network servicification.

BUG= 844965 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If09ae972d4e4c0d0015f862774410d99bbe9b876
Reviewed-on: https://chromium-review.googlesource.com/1143709
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578443}
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/chrome/browser/search/suggestions/suggestions_service_factory.cc
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/DEPS
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl.h
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/components/suggestions/suggestions_service_impl_unittest.cc
[modify] https://crrev.com/05e02f2c0db74dd5d08f9331033c9f4b7c0e7212/ios/chrome/browser/suggestions/suggestions_service_factory.mm

is this migrated? can we close?
Status: Fixed (was: Started)

Sign in to add a comment