New issue
Advanced search Search tips

Issue 844963 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Migrate components/signin/core/browser/gaia_cookie_manager_service.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: morlovich@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7abec3b00d4be4a85ad5154d964fec83ec8b9a

commit 9f7abec3b00d4be4a85ad5154d964fec83ec8b9a
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Jun 21 15:40:41 2018

S13n: port GaiaCookieManagerService to SimpleURLLoader from URLFetcher

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.

Note that this only covers the code immediately here; the underlying
google_apis/gaia code is unchanged.

Bug:  844963 
Change-Id: I9ba41c0c7cbb3a996db49d437b421d65f7e9c8ee
Reviewed-on: https://chromium-review.googlesource.com/1087412
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569271}
[modify] https://crrev.com/9f7abec3b00d4be4a85ad5154d964fec83ec8b9a/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/9f7abec3b00d4be4a85ad5154d964fec83ec8b9a/components/signin/core/browser/gaia_cookie_manager_service.h
[modify] https://crrev.com/9f7abec3b00d4be4a85ad5154d964fec83ec8b9a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment