New issue
Advanced search Search tips

Issue 844962 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Migrate components/search_provider_logos/logo_tracker.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: morlovich@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce7476954ac17a895bfb09916c0cec2284b1773f

commit ce7476954ac17a895bfb09916c0cec2284b1773f
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Jun 13 15:28:32 2018

S13n: port components/search_provider_logos/logo_tracker.cc to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.

Bug:  844962 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib50b46a96349606462f127f25f13d80b4daebec1
Reviewed-on: https://chromium-review.googlesource.com/1095594
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566839}
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/chrome/browser/search_provider_logos/logo_service_factory.cc
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/BUILD.gn
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/DEPS
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/logo_service_impl.h
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/logo_service_impl_unittest.cc
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/components/search_provider_logos/logo_tracker.h
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/ios/chrome/browser/google/google_logo_service.h
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/ios/chrome/browser/google/google_logo_service.mm
[modify] https://crrev.com/ce7476954ac17a895bfb09916c0cec2284b1773f/ios/chrome/browser/google/google_logo_service_factory.mm

Status: Fixed (was: Started)

Sign in to add a comment