New issue
Advanced search Search tips

Issue 844951 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 773295



Sign in to add a comment

Migrate components/policy/core/common/cloud to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Blocking: 773295
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4

commit cb02821074ba14de3d6a503ef204b694b25017a4
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Jun 19 15:40:30 2018

Annotate many of the browser_tests disabled under the NetworkService.

Also remove a couple that either no longer exist, have been disabled
generally due to flakiness, or are now passing.

BUG= 844950 ,  844951 ,  844952 ,  853251 ,  844928 ,
BUG= 843205 ,  844949 ,  844925 ,  844939 , 821021,
BUG=853798,  844973 ,  844927 ,  844926 ,  844950 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I094a012fe2076c7badf86a094140c7d74db183be
Reviewed-on: https://chromium-review.googlesource.com/1104802
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568464}
[modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Owner: ----
Status: Available (was: Started)
 Issue 844952  has been merged into this issue.
Components: Enterprise

Comment 8 by pmarko@chromium.org, Jun 27 2018

Labels: Enterprise-Triaged
Owner: reillyg@chromium.org
Status: Assigned (was: Available)
I am going to get started on this.
Cc: morlovich@chromium.org
Hi Reilly, are you looking at just external_data_policy_fetcher.cc as part of this? There is a bunch of cloudprint stuff that sort of awkwardly got bugfolded into this which may need to have its bug resurrected if that's the case..
Never mind that, the cloudprint bug was just missing a label.
Status: Started (was: Assigned)
Summary: Migrate components/policy/core/common/cloud to network::SimpleURLLoader (was: Migrate components/policy/core/common/cloud/external_policy_data_fetcher.cc)
I originally merged  issue 844952  into this issue because I assumed that updating one class in components/policy/core/common/cloud to network::SimpleURLLoader would probably lead to migrating another. I'm not entirely sure yet but I think UserInfoFetcher and ExternalPolicyDataFetcher are actually reasonably independent. That change for the latter is getting a little large. I will probably work on UserInfoFetcher separately.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f714c69c17afcb32e6254f9f9386c77e29b3d59

commit 1f714c69c17afcb32e6254f9f9386c77e29b3d59
Author: Reilly Grant <reillyg@google.com>
Date: Wed Aug 01 15:11:11 2018

Port policy::ExternalPolicyDataFetcher to network::SimpleURLLoader

This change ports ExternalPolicyDataFetcher from net::URLFetcher to
SimpleURLLoader.

Bug:  844951 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4ec5dcc5904f3bb1f35ec5c8ba8c30865d5cc126
Reviewed-on: https://chromium-review.googlesource.com/1139229
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579807}
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_external_data_service.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_policy_service.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_cloud_external_data_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_cloud_external_data_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/cloud_external_data_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/cloud_policy_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/cloud_policy_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/component_cloud_policy_service.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/component_cloud_policy_service.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/component_cloud_policy_service_stub.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/external_policy_data_fetcher.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/mock_cloud_external_data_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/mock_cloud_external_data_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/mock_cloud_policy_client.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/mock_cloud_policy_client.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/user_cloud_policy_manager.h
[modify] https://crrev.com/1f714c69c17afcb32e6254f9f9386c77e29b3d59/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47285da86eb5a33d494aca906e8b593f1a70197f

commit 47285da86eb5a33d494aca906e8b593f1a70197f
Author: Reilly Grant <reillyg@google.com>
Date: Thu Aug 02 01:23:24 2018

Port policy::UserInfoFetcher to network::SimpleURLLoader

This change ports UserInfoFetcher from net::URLFetcher to
SimpleURLLoader. This was the last user of the
net::URLRequestContextGetter provided by policy::CloudPolicyClient and
so this has been removed.

Bug:  844951 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I752a16fbfcaa92419c79693d2379b918e04b7b9a
Reviewed-on: https://chromium-review.googlesource.com/1156049
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580023}
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/android/signin/signin_manager_android.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/login/auth/chrome_login_performer.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/device_local_account_policy_service.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/chromeos/policy/wildcard_login_checker.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/chrome_browser_policy_connector.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/machine_level_user_cloud_policy_helper.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_base.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_base.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_factory.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_mobile.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/policy/machine_level_user_cloud_policy_controller.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/DEPS
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/browser/browser_policy_connector.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/browser/browser_policy_connector_ios.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/browser/browser_policy_connector_ios.mm
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/DEPS
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_external_data_manager.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_policy_client.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/component_cloud_policy_service_stub.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/device_management_service.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/device_management_service_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/external_policy_data_fetcher.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/mock_cloud_policy_client.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/policy_header_service_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_cloud_policy_manager.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_info_fetcher.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_info_fetcher.h
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/cloud/user_info_fetcher_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/47285da86eb5a33d494aca906e8b593f1a70197f/services/network/test/test_url_loader_factory.h

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76c5d8157741712fab9cd071e654eccee35d3ed8

commit 76c5d8157741712fab9cd071e654eccee35d3ed8
Author: Reilly Grant <reillyg@google.com>
Date: Thu Aug 02 22:45:22 2018

Enable additional policy tests with Network Service

These tests are now passing.

Bug:  844951 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0c886537f94ae525999e88485df41416ddc77752
Reviewed-on: https://chromium-review.googlesource.com/1161293
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580359}
[modify] https://crrev.com/76c5d8157741712fab9cd071e654eccee35d3ed8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)
Hi Reilly,
Could you please provide steps to verify the fix. Thanks.!
Status: Assigned (was: Fixed)
Labels: Pri-2 Type-Task
Status: Fixed (was: Assigned)
I am not aware of the manual testing steps for this feature. All existing unit tests pass. This work was not fixing a bug, but migrating existing code to a new API.
Status: Verified (was: Fixed)
Thanks.! Reilly,
Closing the issue as verified as per your confirmation. 

Sign in to add a comment