New issue
Advanced search Search tips

Issue 844949 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Migrate components/payments/core/payment_manifest_downloader.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)

Comment 2 by jam@chromium.org, Jun 18 2018

 Issue 853778  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4

commit cb02821074ba14de3d6a503ef204b694b25017a4
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Jun 19 15:40:30 2018

Annotate many of the browser_tests disabled under the NetworkService.

Also remove a couple that either no longer exist, have been disabled
generally due to flakiness, or are now passing.

BUG= 844950 ,  844951 ,  844952 ,  853251 ,  844928 ,
BUG= 843205 ,  844949 ,  844925 ,  844939 , 821021,
BUG=853798,  844973 ,  844927 ,  844926 ,  844950 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I094a012fe2076c7badf86a094140c7d74db183be
Reviewed-on: https://chromium-review.googlesource.com/1104802
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568464}
[modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 4 by jam@chromium.org, Jun 19 2018

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef36cb70172fd9908e6064542a54fd6feda54da

commit aef36cb70172fd9908e6064542a54fd6feda54da
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jun 26 17:18:23 2018

Convert PaymentManifestDownloader to use SimpleURLLoader.

Also while updating these unittests, I realized contextual_suggestions_fetcher_impl_unittest.cc and feed_networking_host_unittest.cc can be simplified so I updated them.

Bug:  844949 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2a527c2f854a29d0809ab57c81599e813a8146dc
Reviewed-on: https://chromium-review.googlesource.com/1107487
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Moe Ahmadi (OOO until July 3) <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570440}
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/chrome/browser/payments/manifest_verifier_browsertest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/chrome/browser/ui/views/payments/payment_request_payment_app_browsertest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/feed/core/feed_networking_host_unittest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/ntp_snippets/contextual/contextual_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/content/android/DEPS
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/content/android/payment_manifest_downloader_android.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/content/android/payment_manifest_downloader_android.h
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/content/service_worker_payment_app_factory.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/BUILD.gn
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/DEPS
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/payment_manifest_downloader.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/payment_manifest_downloader.h
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/payment_manifest_downloader_unittest.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/test_payment_manifest_downloader.cc
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/components/payments/core/test_payment_manifest_downloader.h
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/ios/chrome/browser/payments/ios_payment_instrument_finder.h
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/ios/chrome/browser/payments/ios_payment_instrument_finder.mm
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/aef36cb70172fd9908e6064542a54fd6feda54da/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 6 by jam@chromium.org, Jun 26 2018

Status: Fixed (was: Started)

Sign in to add a comment