New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844947 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 8
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/password_manager/core/browser to network::SimpleURLLoader

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Owner: ----
Status: Available (was: Started)
 Issue 844948  has been merged into this issue.
Blocking: 773295
Components: UI>Browser>Passwords
Summary: Migrate components/password_manager/core/browser to network::SimpleURLLoader (was: Migrate components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/176a3a3154870bc3e0722934c03d6dc3b5dae748

commit 176a3a3154870bc3e0722934c03d6dc3b5dae748
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Thu Jul 12 17:48:34 2018

Migrate AffiliationFetcher to SimpleURLLoader

Bug:  844947 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I08b3921d4a6e8ad2489a175cea5a5b883af32bbb
Reviewed-on: https://chromium-review.googlesource.com/1129322
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574627}
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_backend.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_backend.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_service.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_service.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/176a3a3154870bc3e0722934c03d6dc3b5dae748/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc

Components: Internals>Services>Network
Labels: Pri-1
Owner: ----
Status: Available (was: Started)
Looks like AssetLinkRetriever still uses URLFetcher, so this isn't done yet.
FRT: https://crrev.com/c/1135591 (Remove unused AssetLinkRetriever).
Owner: pilgrim@chromium.org
Status: Fixed (was: Available)
pilgrim fixed it in 


  commit 176a3a3154870bc3e0722934c03d6dc3b5dae748
  Author: Mark Pilgrim <pilgrim@chromium.org>
  Date: Thu Jul 12 17:48:34 2018

  Migrate AffiliationFetcher to SimpleURLLoader

  Bug:  844947 
  (..)

and

  commit 1543431a9367f9bc41721e3dfc1eb42e708aaeda
  Author: Mark Pilgrim <pilgrim@chromium.org>
  Date: Wed Jul 18 18:00:11 2018

  Remove unused AssetLinkRetriever
  (..)

.

Sign in to add a comment