New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844943 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/ntp_tiles/popular_sites_impl.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60a21d3ac362c31fc56681fcdacf5e15cb9a6220

commit 60a21d3ac362c31fc56681fcdacf5e15cb9a6220
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed May 30 15:37:40 2018

Migrate PopularSitesImpl to SimpleURLLoader

As part of the effort to bring the new Network Service online, we are
deprecating URLFetcher in favor of SimpleURLLoader.

Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit

Bug:  844943 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I77ec8b2c4ff6a11995f3b6c2ec911c94b16789e4
Reviewed-on: https://chromium-review.googlesource.com/1076596
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562838}
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/BUILD.gn
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/DEPS
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/popular_sites_impl.h
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/ios/chrome/browser/ntp_tiles/BUILD.gn
[modify] https://crrev.com/60a21d3ac362c31fc56681fcdacf5e15cb9a6220/ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment