New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844942 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/ntp_snippets/remote/json_request.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da33faa23dc32a4553de3e72294db28ff1653572

commit da33faa23dc32a4553de3e72294db28ff1653572
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed Jun 06 14:29:47 2018

Migrate ntp_snippets::JsonRequest to SimpleURLLoader

Bug:  844942 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifda80b4277d7d4ad6f1336de6f437aa82ff75c29
Reviewed-on: https://chromium-review.googlesource.com/1087174
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564875}
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/json_request.h
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/json_request_unittest.cc
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/da33faa23dc32a4553de3e72294db28ff1653572/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment