New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844940 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/ntp_snippets/breaking_news/subscription_json_request.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b

commit be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue Jun 05 00:20:14 2018

Migrate SubscriptionJsonRequest to SimpleURLLoader

Bug:  844940 
Change-Id: I714d4b403345a3d44b82f217c4e3c103f6a7142e
Reviewed-on: https://chromium-review.googlesource.com/1082713
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564310}
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_json_request.cc
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_json_request.h
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_json_request_unittest.cc
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_manager_impl.cc
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_manager_impl.h
[modify] https://crrev.com/be8a88ad8d7e4fcdc9b0256f0aa20ddb02cfe88b/components/ntp_snippets/breaking_news/subscription_manager_impl_unittest.cc

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment