Issue 853783 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4 commit cb02821074ba14de3d6a503ef204b694b25017a4 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jun 19 15:40:30 2018 Annotate many of the browser_tests disabled under the NetworkService. Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG= 844950 , 844951 , 844952 , 853251 , 844928 , BUG= 843205 , 844949 , 844925 , 844939 , 821021, BUG=853798, 844973 , 844927 , 844926 , 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464} [modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a52618c0dfff4f164f6876442519f7a199bc627 commit 0a52618c0dfff4f164f6876442519f7a199bc627 Author: John Abd-El-Malek <jam@chromium.org> Date: Tue Jun 19 18:06:04 2018 Convert NetworkTimeTracker to use SimpleURLLoader. Since the relevant unit tests make real network requests, create network::TestSharedURLLoaderFactory helper class which is a network-service compatible version of net::TestURLRequestContextGetter. Use it instead of the one-offs in existing safe-browsing unit tests. Bug: 844939 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I905f29fda62f9e27905e3705b3d85c64ba13ae94 Reviewed-on: https://chromium-review.googlesource.com/1104795 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568528} [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/safe_browsing/download_protection/download_feedback_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/safe_browsing/download_protection/two_phase_uploader_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/ssl/certificate_error_report_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/browser/ssl/ssl_error_handler_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/network_time/BUILD.gn [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/network_time/DEPS [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/network_time/network_time_tracker.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/network_time/network_time_tracker.h [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/network_time/network_time_tracker_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/ssl_errors/BUILD.gn [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/ssl_errors/DEPS [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/components/ssl_errors/error_classification_unittest.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/ios/chrome/test/testing_application_context.mm [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/services/network/BUILD.gn [add] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/services/network/test/test_shared_url_loader_factory.cc [add] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/services/network/test/test_shared_url_loader_factory.h [modify] https://crrev.com/0a52618c0dfff4f164f6876442519f7a199bc627/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)