The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a15597069fc893827d4507d54731af461ab369b4 commit a15597069fc893827d4507d54731af461ab369b4 Author: Mark Pilgrim <pilgrim@chromium.org> Date: Fri May 25 13:24:45 2018 Migrate AssistRanker to SimpleURLLoader As part of the effort to bring the new Network Service online, we are deprecating URLFetcher in favor of SimpleURLLoader. Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit Bug: 844937 Change-Id: I4a00c42b481f10c03657aa52b9a3d197febdc6ed Reviewed-on: https://chromium-review.googlesource.com/1070110 Reviewed-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561845} [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/chrome/browser/assist_ranker/assist_ranker_service_factory.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/chrome/browser/translate/translate_service.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/BUILD.gn [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/DEPS [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/assist_ranker_service_impl.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/assist_ranker_service_impl.h [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/binary_classifier_predictor.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/binary_classifier_predictor.h [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/ranker_model_loader_impl.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/ranker_model_loader_impl.h [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/ranker_model_loader_impl_unittest.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/ranker_url_fetcher.cc [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/assist_ranker/ranker_url_fetcher.h [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/translate/DEPS [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/translate/core/browser/translate_download_manager.h [modify] https://crrev.com/a15597069fc893827d4507d54731af461ab369b4/components/translate/core/browser/translate_ranker_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bfb7d64f0119093521d68128f1a8ef08f0ceb67 commit 2bfb7d64f0119093521d68128f1a8ef08f0ceb67 Author: Luna Lu <loonybear@chromium.org> Date: Fri May 25 19:16:33 2018 Revert "Migrate AssistRanker to SimpleURLLoader" This reverts commit a15597069fc893827d4507d54731af461ab369b4. Reason for revert: Suspect causing theses tests to fail: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10013 RankerModelLoaderImplTest.BadLocalAndRemoteModel RankerModelLoaderImplTest.IncompatibleCachedFileTriggersDownload RankerModelLoaderImplTest.LoadFromExpiredFileTriggersDownload RankerModelLoaderImplTest.LoadFromBadFileTriggersDownload RankerModelLoaderImplTest.LoadFromURLOnly RankerModelLoaderImplTest.LoadFromFileAndBadUrl RankerModelLoaderImplTest.IncompatibleDownloadedFileKeepsExpired Original change's description: > Migrate AssistRanker to SimpleURLLoader > > As part of the effort to bring the new Network Service online, we are > deprecating URLFetcher in favor of SimpleURLLoader. > > Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit > > Bug: 844937 > Change-Id: I4a00c42b481f10c03657aa52b9a3d197febdc6ed > Reviewed-on: https://chromium-review.googlesource.com/1070110 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561845} TBR=groby@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,amoylan@chromium.org,charleszhao@chromium.org Change-Id: I486df02edd2d762c0a0f93449d47aafdf5337f27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844937 Reviewed-on: https://chromium-review.googlesource.com/1073656 Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561966} [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/chrome/browser/assist_ranker/assist_ranker_service_factory.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/chrome/browser/translate/translate_service.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/BUILD.gn [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/DEPS [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/assist_ranker_service_impl.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/assist_ranker_service_impl.h [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/binary_classifier_predictor.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/binary_classifier_predictor.h [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/ranker_model_loader_impl.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/ranker_model_loader_impl.h [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/ranker_model_loader_impl_unittest.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/ranker_url_fetcher.cc [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/assist_ranker/ranker_url_fetcher.h [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/translate/DEPS [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/translate/core/browser/translate_download_manager.h [modify] https://crrev.com/2bfb7d64f0119093521d68128f1a8ef08f0ceb67/components/translate/core/browser/translate_ranker_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389b08fae3e16a510497e093e84243c232bdf14a commit 389b08fae3e16a510497e093e84243c232bdf14a Author: Mark Pilgrim <pilgrim@chromium.org> Date: Wed May 30 13:20:13 2018 Reland Migrate AssistRanker to SimpleURLLoader As part of the effort to bring the new Network Service online, we are deprecating URLFetcher in favor of SimpleURLLoader. Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1070110 Reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1073656 Refactoring exposed an underlying bug in the existing code (max_retries_on_5xx_ could be used before being initialized). This CL initializes it to 0 in the constructor. Bug: 844937 Change-Id: I419565dc899b2b48118b351206ade4f15090836a TBR: groby@chromium.org, charleszhao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1076407 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562806} [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/chrome/browser/assist_ranker/assist_ranker_service_factory.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/chrome/browser/translate/translate_service.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/BUILD.gn [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/DEPS [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/assist_ranker_service_impl.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/assist_ranker_service_impl.h [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/binary_classifier_predictor.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/binary_classifier_predictor.h [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/ranker_model_loader_impl.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/ranker_model_loader_impl.h [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/ranker_model_loader_impl_unittest.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/ranker_url_fetcher.cc [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/assist_ranker/ranker_url_fetcher.h [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/translate/DEPS [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/translate/core/browser/translate_download_manager.h [modify] https://crrev.com/389b08fae3e16a510497e093e84243c232bdf14a/components/translate/core/browser/translate_ranker_impl.cc
Comment 1 by dxie@google.com
, May 20 2018Status: Available (was: Untriaged)