New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844936 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/invalidation/impl/gcm_network_channel.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7e9d36297328550aa01eb0dd3a4fee86b390ef

commit 6a7e9d36297328550aa01eb0dd3a4fee86b390ef
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Fri Jun 29 17:49:10 2018

Migrate GCMNetworkChannel to SimpleURLLoader

TBR=bartfab@chromium.org

Bug:  844936 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I573698e0994b6dc6e70f0d17e6dcbbb83aa1a142
Reviewed-on: https://chromium-review.googlesource.com/1102725
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571533}
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/chrome/browser/invalidation/profile_invalidation_provider_factory.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/gcm_network_channel.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/gcm_network_channel.h
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/gcm_network_channel_unittest.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/non_blocking_invalidator.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/non_blocking_invalidator.h
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/sync_system_resources.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/sync_system_resources.h
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/ticl_invalidation_service.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/ticl_invalidation_service.h
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/ticl_invalidation_service_unittest.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/components/invalidation/impl/ticl_profile_settings_provider_unittest.cc
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/6a7e9d36297328550aa01eb0dd3a4fee86b390ef/services/network/public/cpp/shared_url_loader_factory.cc

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment