New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844934 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 773295



Sign in to add a comment

Migrate components/history/core/browser/web_history_service.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c8d34f6f3b1efbc7faf42c3282058629a904a0d

commit 1c8d34f6f3b1efbc7faf42c3282058629a904a0d
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Fri May 25 13:24:58 2018

Migrate WebHistoryService to SimpleURLLoader

Bug:  844934 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I480fe2d42be09e6b295f5e7f1e53548e1e912ede
Reviewed-on: https://chromium-review.googlesource.com/1072048
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561846}
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/chrome/browser/browsing_data/counters/history_counter_browsertest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/chrome/browser/browsing_data/counters/sync_aware_counter_browsertest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/DEPS
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/browser/browsing_history_service_unittest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/browser/web_history_service.h
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/browser/web_history_service_unittest.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/test/BUILD.gn
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/test/fake_web_history_service.cc
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/components/history/core/test/fake_web_history_service.h
[modify] https://crrev.com/1c8d34f6f3b1efbc7faf42c3282058629a904a0d/ios/chrome/browser/history/web_history_service_factory.cc

Blocking: 773295
Status: Fixed (was: Started)

Sign in to add a comment