New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844933 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: ----



Sign in to add a comment

Migrate components/gcm_driver/gcm_channel_status_request.cc

Project Member Reported by dxie@google.com, May 20 2018

Issue description


 

Comment 1 by dxie@google.com, May 20 2018

Labels: Proj-Servicification-Canary Proj-Servicification OS-Windows OS-Linux OS-Mac OS-Chrome Proj-Servicification-network-url OS-Android
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7634f5b50428e825f5fe79ac1fd69fa5515e5182

commit 7634f5b50428e825f5fe79ac1fd69fa5515e5182
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed Jun 27 19:53:27 2018

Migrate GCMChannelStatusRequest to SimpleURLLoader

Bug:  844933 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0f23e77a0907b8def0c4f962cea7910fbc75469f
Reviewed-on: https://chromium-review.googlesource.com/1113669
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570872}
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/DEPS
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_channel_status_request.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_channel_status_request.h
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_channel_status_request_unittest.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_channel_status_syncer.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_channel_status_syncer.h
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_desktop_utils.h
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_driver_desktop.h
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_driver_desktop_unittest.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/7634f5b50428e825f5fe79ac1fd69fa5515e5182/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment